-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
libpq: Avoid broken symlinks in include/catalog #25355
libpq: Avoid broken symlinks in include/catalog #25355
Conversation
To avoid broken symlinks, do out of source build. Change `build()` and `package()` method to do out of source build. Copy the backend catalog from the source tree. Note: the `MSVC` part is ignored in this commit.
This comment has been minimized.
This comment has been minimized.
Conan v1 pipeline ✔️Warning Conan Center will stop receiving updates for Conan 1.x packages soon - please see announcement. All green in build 2 (
Conan v2 pipeline ✔️
All green in build 2 (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
9eef91f
* (conan-io#24895) Avoid broken symlinks in include/catalog To avoid broken symlinks, do out of source build. Change `build()` and `package()` method to do out of source build. Copy the backend catalog from the source tree. Note: the `MSVC` part is ignored in this commit. * remove old versions * remove unreachable code --------- Co-authored-by: Ernesto de Gracia Herranz <[email protected]>
Summary
Changes to recipe: libpq/[*]
Motivation
See #24895
Details
To avoid broken symlinks, do out of source build.
Change
build()
andpackage()
method to do out of source build.Copy the backend catalog from the source tree.
Note: the
MSVC
part is ignored in this PR.I ran the tests for some configurations:
https://gitlab.com/scandyna/conan-center-index-partialbasicci-sandbox/-/pipelines/1463949508
Notes about the Windows builds:
test_v1_package
fails. Probably something missing in my environment (I don't use thecmake
generator anymore)test_package
fails due to undefined references. This is also the case without the changes in this PR (I opened another issue for this case, 25282)