Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libpq: Avoid broken symlinks in include/catalog #25355

Merged

Conversation

scandyna
Copy link
Contributor

Summary

Changes to recipe: libpq/[*]

Motivation

See #24895

Details

To avoid broken symlinks, do out of source build.
Change build() and package() method to do out of source build.
Copy the backend catalog from the source tree.
Note: the MSVC part is ignored in this PR.


I ran the tests for some configurations:
https://gitlab.com/scandyna/conan-center-index-partialbasicci-sandbox/-/pipelines/1463949508

Notes about the Windows builds:

  • For MSVC, the test_v1_package fails. Probably something missing in my environment (I don't use the cmake generator anymore)
  • For MinGW, the test_package fails due to undefined references. This is also the case without the changes in this PR (I opened another issue for this case, 25282)

To avoid broken symlinks, do out of source build.
Change `build()` and `package()` method to do out of source build.
Copy the backend catalog from the source tree.
Note: the `MSVC` part is ignored in this commit.
@CLAassistant
Copy link

CLAassistant commented Sep 22, 2024

CLA assistant check
All committers have signed the CLA.

@scandyna scandyna mentioned this pull request Sep 22, 2024
@scandyna scandyna changed the title libpq: Avoid broken symlinks in include/catalog #24895 libpq: Avoid broken symlinks in include/catalog Sep 22, 2024
@conan-center-bot

This comment has been minimized.

@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

Warning

Conan Center will stop receiving updates for Conan 1.x packages soon - please see announcement.

All green in build 2 (3b5043ff57529db3a493724dae1d79f2801cf809):

  • libpq/13.12:
    Built 20 packages out of 22 (All logs)

  • libpq/10.23:
    Built 20 packages out of 22 (All logs)

  • libpq/15.4:
    Built 20 packages out of 22 (All logs)

  • libpq/15.5:
    Built 20 packages out of 22 (All logs)

  • libpq/14.9:
    Built 20 packages out of 22 (All logs)

  • libpq/12.16:
    Built 20 packages out of 22 (All logs)

  • libpq/11.21:
    Built 20 packages out of 22 (All logs)

  • libpq/15.3:
    Built 20 packages out of 22 (All logs)

  • libpq/9.6.24:
    Built 20 packages out of 22 (All logs)


Conan v2 pipeline ✔️

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

All green in build 2 (3b5043ff57529db3a493724dae1d79f2801cf809):

  • libpq/15.4:
    All packages built successfully! (All logs)

  • libpq/15.3:
    All packages built successfully! (All logs)

  • libpq/14.9:
    All packages built successfully! (All logs)

  • libpq/15.5:
    All packages built successfully! (All logs)

  • libpq/13.12:
    All packages built successfully! (All logs)

  • libpq/12.16:
    All packages built successfully! (All logs)

  • libpq/11.21:
    All packages built successfully! (All logs)

  • libpq/10.23:
    All packages built successfully! (All logs)

  • libpq/9.6.24:
    All packages built successfully! (All logs)

@ErniGH ErniGH self-assigned this Nov 20, 2024
ErniGH
ErniGH previously approved these changes Nov 20, 2024
Copy link
Contributor

@ErniGH ErniGH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

AbrilRBS
AbrilRBS previously approved these changes Nov 20, 2024
perseoGI
perseoGI previously approved these changes Nov 20, 2024
@ErniGH ErniGH dismissed stale reviews from perseoGI, AbrilRBS, and themself via 9eef91f November 20, 2024 17:03
@jcar87 jcar87 merged commit 1a29748 into conan-io:master Nov 20, 2024
9 checks passed
OMGtechy pushed a commit to OMGtechy/conan-center-index that referenced this pull request Dec 31, 2024
* (conan-io#24895) Avoid broken symlinks in include/catalog

To avoid broken symlinks, do out of source build.
Change `build()` and `package()` method to do out of source build.
Copy the backend catalog from the source tree.
Note: the `MSVC` part is ignored in this commit.

* remove old versions

* remove unreachable code

---------

Co-authored-by: Ernesto de Gracia Herranz <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants