fix(fortal): restore dialog and popover layout defaults - #129
Merged
Conversation
leoafarias
marked this pull request as ready for review
August 10, 2026 19:44
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Restores the layout defaults declared by the pinned Radix 3.3.0 parity manifest:
FortalDialognow defaults to centered placement and a maximum width of 600 logical pixels.FortalDialogAlign.startopts into top-centered placement.FortalPopovernow has a maximum width of 480 logical pixels.Previously, expanding dialog and popover children could produce unconstrained surfaces, and dialog callers had to add their own
Centerwrapper even though centered placement was the declared default.Examples
Before, callers centered dialogs manually:
Now centering and the 600-pixel maximum width are defaults:
Top-centered placement is explicit:
Popover content is constrained by the Fortal preset even when a child requests more space:
Validation
fvm flutter analyze --fatal-infosfrompackages/remix_fortalfvm dart run melos run ci --no-select, including clean code generation, docs validation, Fortal parity checks, and all package testsRelated Issues
Closes #128.
Checklist
Note: Updating the
pubspec.yamlandCHANGELOG.mdis not required. These are handled automatically during the release process.///).Breaking Change
Does this PR require users of the package to manually update their code?