feat: add iconAlignment - #29
Merged
Merged
Conversation
|
To view this pull requests documentation preview, visit the following URL: Documentation is deployed and generated using docs.page. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds the ability to control icon alignment in the RemixButton component, allowing icons to be positioned either before (start) or after (end) the button label.
Key Changes
- Added
iconAlignmentproperty to RemixButtonSpec with a default value ofIconAlignment.start - Added
iconAlignment()method to RemixButtonStyle for fluent API usage - Refactored button_widget.dart to conditionally order icon and text based on alignment setting
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| button_spec.dart | Adds iconAlignment field to the spec with default value, updates constructor, copyWith, lerp, diagnostics, and equality |
| button_style.dart | Adds iconAlignment parameter to style constructors and provides fluent API method for setting alignment |
| button_widget.dart | Implements icon alignment logic using switch expression and refactors spinner creation (removes unnecessary Center wrapper) |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Added checks for the new iconAlignment property in the RemixButtonSpec tests, updating property counts and assertions to ensure full coverage.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the ability to control icon alignment in the RemixButton component, allowing icons to be positioned either before (start) or after (end) the button label.
Key Changes
Added iconAlignment property to RemixButtonSpec with a default value of IconAlignment.start
Added iconAlignment() method to RemixButtonStyle for fluent API usage
Refactored button_widget.dart to conditionally order icon and text based on alignment setting
Checklist
Note: Updating the
pubspec.yamlandCHANGELOG.mdis not required. These are handled automatically during the release process.///).Breaking Change
Does this PR require users of the package to manually update their code?