Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark libiconv 1.18=*_0 on Windows as broken due to a ABI break #1395

Merged
merged 1 commit into from
Feb 19, 2025

Conversation

traversaro
Copy link
Contributor

@traversaro traversaro commented Feb 19, 2025

The libiconv 1.18=*_0 build on Windows contains an ABI break that creates a problem in pkg-config and due to the use of pkg-config in a activation script, also in the installation of any package that depends (even transitively) on gdk-pixbuf . While we look into a fix, the best option is to mark the problematic package as broken.

Related issues:

Checklist:

  • I want to mark a package as broken (or not broken):
    • Added a description of the problem with the package in the PR description.
    • Pinged the team for the package for their input.

@conda-forge/core @conda-forge/libiconv @conda-forge/pkg-config @conda-forge/gdk-pixbuf @conda-forge/vtk @conda-forge/ffmpeg

@traversaro traversaro requested a review from a team as a code owner February 19, 2025 08:59
Comment on lines +2 to +3
packages:
- win-64/libiconv-1.18-h135ad9c_0.conda
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we mark all 1.18 builds as broken? I think this makes for a saner mental model of the ecosystem, aside from the fact that - a priori - those symbol removals might also be observable on unix under some circumstances?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we mark all 1.18 builds as broken? I think this makes for a saner mental model of the ecosystem, aside from the fact that - a priori - those symbol removals might also be observable on unix under some circumstances?

I explicitly checked and there is no ABI regression on Linux, see conda-forge/libiconv-feedstock#48 (comment) , and I guess this is expected as I think the regression in our vendored CMakeLists.txt build system used on Windows. I did not marked as broken the *nix packages for 1.18 to avoid unwanted regression on packages that were already built again libiconv 1.18 and so a have a libiconv>=1.18 run constraint, but I get your point, so if you like I can add also all other 1.18 builds as broken.

Copy link
Member

@h-vetinari h-vetinari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK. I would have preferred to just retire 1.18 entirely, but let's merge this to stop the bleeding.

@h-vetinari h-vetinari merged commit 8a74232 into conda-forge:main Feb 19, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants