Skip to content

Conversation

@RaulPPelaez
Copy link
Contributor

@RaulPPelaez RaulPPelaez commented Apr 11, 2025

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@RaulPPelaez RaulPPelaez requested a review from traversaro as a code owner April 11, 2025 08:40
@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found some lint.

Here's what I've got...

For recipe/meta.yaml:

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/14399174330. Examine the logs at this URL for more detail.

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

@traversaro
Copy link
Contributor

@conda-forge-admin please rerender

@traversaro
Copy link
Contributor

fyi @conda-forge/pyglm @conda-forge/helios @conda-forge/pydelatin @conda-forge/pymol-open-source @conda-forge/cpp-hmm glm was not changed in a long time (also has somehow the autoupdate bot was not working on it?), just paging you (as your feedstock depend on glm) you know to let you know about this glm update.

@traversaro
Copy link
Contributor

I guess we need to disable -Werror (see for example ros-misc-utilities/ffmpeg_encoder_decoder#2 for some context) @RaulPPelaez can you handle that? Thanks!

@RaulPPelaez
Copy link
Contributor Author

Tests are passing, I removed this patch: patches/cmake_install_target.patch. Does your new test case cover what this patch was fixing?

@traversaro
Copy link
Contributor

Tests are passing, I removed this patch: patches/cmake_install_target.patch. Does your new test case cover what this patch was fixing?

Yes!

@traversaro
Copy link
Contributor

Thanks for the fast feedback and for the contribution!

@traversaro traversaro added the automerge Merge the PR when CI passes label Apr 11, 2025
@conda-forge-admin conda-forge-admin merged commit 7836436 into conda-forge:main Apr 11, 2025
9 checks passed
@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly conda-forge automerge bot!

I considered the following status checks when analyzing this PR:

  • linter: passed
  • azure: passed

Thus the PR was passing and merged! Have a great day!

@RaulPPelaez RaulPPelaez deleted the 101 branch April 11, 2025 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

automerge Merge the PR when CI passes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants