Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Un-pin Pydantic #23

Closed
wants to merge 3 commits into from
Closed

Un-pin Pydantic #23

wants to merge 3 commits into from

Conversation

SimonBoothroyd
Copy link

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe/meta.yaml:

  • No valid build backend found for Python recipe for package openff-bespokefit using pip. Python recipes using pip need to explicitly specify a build backend in the host section. If your recipe has built with only pip in the host section in the past, you likely should add setuptools to the host section of your recipe.

@SimonBoothroyd
Copy link
Author

@mattwthompson I think 0.3.0 has the try / catch to handle v1 and v2 right?

@SimonBoothroyd
Copy link
Author

@conda-forge-admin, please rerender

conda-forge-webservices[bot] and others added 2 commits September 5, 2024 07:44
@j-wags
Copy link
Contributor

j-wags commented Sep 5, 2024

Checking pydantic 2 compatibility here openforcefield/openff-bespokefit#357

@j-wags
Copy link
Contributor

j-wags commented Sep 5, 2024

The compatibility checks above raise a bunch of errors, even when trying a range of versions of OpenFF ecosystem packages. So I don't think this is ready for release.

@mattwthompson
Copy link
Member

This should work in 0.3.0, yeah: openforcefield/openff-bespokefit@3611f36

@j-wags
Copy link
Contributor

j-wags commented Sep 9, 2024

@mattwthompson - It's possible I'm overlooking something, but bespokefit CI fails if I bring in pydantic 2. Could you clarify?

@mattwthompson
Copy link
Member

Something unexpected is going on: openforcefield/openff-bespokefit#358

@SimonBoothroyd SimonBoothroyd closed this by deleting the head repository Oct 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants