Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding diffusioncma package #11679

Merged
merged 44 commits into from
May 27, 2020
Merged

adding diffusioncma package #11679

merged 44 commits into from
May 27, 2020

Conversation

Olllom
Copy link
Contributor

@Olllom Olllom commented May 20, 2020

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml"
  • License file is packaged (see here for an example)
  • Source is from official source
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged)
  • If static libraries are linked in, the license of the static library is packaged.
  • Build number is 0
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details)
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/diffusioncma) and found some lint.

Here's what I've got...

For recipes/diffusioncma:

  • There are 1 too many lines. There should be one empty line at the end of the file.
  • about/license_family 'GNU' not allowed. Allowed families are AGPL,
    APACHE, BSD, CC, GPL, GPL2, GPL3, LGPL, MIT, MOZILLA, NONE, OTHER,
    PROPRIETARY, PSF, and PUBLIC-DOMAIN.
  • requirements: build: cmake>=3.12.1 must contain a space between the name and the pin, i.e. cmake >=3.12.1
  • requirements: run: Click>=6.0 must contain a space between the name and the pin, i.e. Click >=6.0

For recipes/diffusioncma:

  • License is not an SPDX identifier (or a custom LicenseRef) nor an SPDX license expression.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/diffusioncma) and found some lint.

Here's what I've got...

For recipes/diffusioncma:

  • There are 1 too many lines. There should be one empty line at the end of the file.

For recipes/diffusioncma:

  • License is not an SPDX identifier (or a custom LicenseRef) nor an SPDX license expression.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/diffusioncma) and found some lint.

Here's what I've got...

For recipes/diffusioncma:

  • There are 1 too many lines. There should be one empty line at the end of the file.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/diffusioncma) and found it was in an excellent condition.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/diffusioncma) and found some lint.

Here's what I've got...

For recipes/diffusioncma:

  • Selectors are suggested to take a <two spaces>#<one space>[<expression>] form. See lines [35]

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/diffusioncma) and found it was in an excellent condition.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/diffusioncma) and found some lint.

Here's what I've got...

For recipes/diffusioncma:

  • Selectors are suggested to take a <two spaces>#<one space>[<expression>] form. See lines [35, 36, 37, 44, 45, 57, 58]

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/diffusioncma) and found it was in an excellent condition.

Olllom added 6 commits May 21, 2020 07:19
previous build worked for py36 and py37 on linux, but libcmaes is not available for py37 on mac
no c++ requirements in run
previous build worked on linux but failed on mac due to invalid compiler flags
previous build worked on linux
target compile features off
@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/diffusioncma) and found some lint.

Here's what I've got...

For recipes/diffusioncma:

  • The build section contained an unexpected subsection name. patches is not a valid subsection name.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/diffusioncma) and found it was in an excellent condition.

@Olllom
Copy link
Contributor Author

Olllom commented May 22, 2020

@conda-forge/help-python ready for review

@Olllom
Copy link
Contributor Author

Olllom commented May 22, 2020

@conda-forge/help-c-cpp ready for review

@Olllom
Copy link
Contributor Author

Olllom commented May 22, 2020

Link to project diffusioncma

recipes/diffusioncma/build.sh Outdated Show resolved Hide resolved
recipes/diffusioncma/meta.yaml Outdated Show resolved Hide resolved
@Olllom Olllom requested review from xhochy, nehaljwani and isuruf May 26, 2020 12:58
recipes/diffusioncma/meta.yaml Outdated Show resolved Hide resolved
recipes/diffusioncma/meta.yaml Outdated Show resolved Hide resolved
Olllom and others added 2 commits May 27, 2020 17:14
@xhochy xhochy merged commit c4f6f7e into conda-forge:master May 27, 2020
@xhochy
Copy link
Member

xhochy commented May 27, 2020

Thanks also for taking care of libcmaes!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

5 participants