-
-
Notifications
You must be signed in to change notification settings - Fork 5.6k
Add Bip32 #23787
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Bip32 #23787
Conversation
|
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipes/bip32:
|
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
|
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipes/bip32:
|
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
|
@conda-forge/help-python-c, hello, ready for review |
DBG: patch no longer needed?
|
@carterbox This should be ready for review now that coincurve is on conda-forge |
|
I'm seeing the tests failing, please fix that before someone comes along to review. I may or may not be reviewing this weekend. |
|
@carterbox Right, the version of coincurve we worked on is 19.0.0, but the recipe calls for 18.0.0, I just updated it to back-populate 18.0.0 (although, I can only do so by using PYPI package as we discussed) |
|
Please work with upstream maintainers of all the packages that you want to add to conda-forge that depend on coincurve to publish a stable release that supports coincurve 19. |
|
@carterbox This recipe is ready for review. Note that I used |
|
@carterbox I have updated |
|
@carterbox I added a patch of the requirements to make the checks pass (or highlight if other issues arise). Upstream is resolving an issue that only affects the way the pypi |
Checklist
url) rather than a repo (e.g.git_url) is used in your recipe (see here for more details).