Skip to content

Conversation

@MementoRC
Copy link
Contributor

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Package does not ship static libraries. If static libraries are needed, follow CFEP-18.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/bip32, recipes/coincurve) and found some lint.

Here's what I've got...

For recipes/bip32:

  • There are too few lines. There should be one empty line at the end of the file.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/bip32, recipes/coincurve) and found it was in an excellent condition.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/bip32, recipes/coincurve) and found some lint.

Here's what I've got...

For recipes/bip32:

  • noarch packages can't have skips with selectors. If the selectors are necessary, please remove noarch: python.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/bip32, recipes/coincurve) and found it was in an excellent condition.

@MementoRC MementoRC marked this pull request as ready for review August 30, 2023 20:44
@MementoRC
Copy link
Contributor Author

@conda-forge/help-python-c, hello, ready for review

@MementoRC MementoRC changed the title Add Bip32 - WIP: Awaiting merge of coincurve PR Add Bip32 Jan 17, 2024
@MementoRC MementoRC marked this pull request as ready for review January 18, 2024 00:01
@MementoRC
Copy link
Contributor Author

@carterbox This should be ready for review now that coincurve is on conda-forge

@carterbox
Copy link
Member

I'm seeing the tests failing, please fix that before someone comes along to review. I may or may not be reviewing this weekend.

@MementoRC
Copy link
Contributor Author

@carterbox Right, the version of coincurve we worked on is 19.0.0, but the recipe calls for 18.0.0, I just updated it to back-populate 18.0.0 (although, I can only do so by using PYPI package as we discussed)
Close/Open to restart the checks

@MementoRC MementoRC closed this Jan 18, 2024
@MementoRC MementoRC reopened this Jan 18, 2024
@carterbox
Copy link
Member

Please work with upstream maintainers of all the packages that you want to add to conda-forge that depend on coincurve to publish a stable release that supports coincurve 19.

@MementoRC MementoRC marked this pull request as ready for review January 21, 2024 20:39
@MementoRC
Copy link
Contributor Author

MementoRC commented Jan 21, 2024

@carterbox This recipe is ready for review. Note that I used coincurve 18.0.0. The upstream maintainer does not seem active (I did post a requst, however)

@carterbox carterbox mentioned this pull request Feb 2, 2024
10 tasks
@MementoRC
Copy link
Contributor Author

@carterbox I have updated coincurve requirement to 19.0.0 - The author is intending to release a new version once we address his static-built-coincurve-windows issue

@MementoRC
Copy link
Contributor Author

MementoRC commented Feb 15, 2024

@carterbox I added a patch of the requirements to make the checks pass (or highlight if other issues arise). Upstream is resolving an issue that only affects the way the pypi coincurve package is built: darosior/python-bip32#40

@carterbox carterbox merged commit 61c03cb into conda-forge:main Feb 16, 2024
@MementoRC MementoRC deleted the bip32 branch February 16, 2024 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants