Skip to content

Commit

Permalink
Release 3.4.2 preparation (#630)
Browse files Browse the repository at this point in the history
* Make rever happy

* Updated authorship for 3.4.2

* Updated CHANGELOG for 3.4.2

* Polish

* Logging fix

* Fix burn-in documentation

* correct pr number

* Update howto.md

* Update howto.md
  • Loading branch information
dbast authored Jan 26, 2023
1 parent 1473bec commit 29ed8bc
Show file tree
Hide file tree
Showing 11 changed files with 33 additions and 106 deletions.
5 changes: 3 additions & 2 deletions .authors.yml
Original file line number Diff line number Diff line change
Expand Up @@ -263,7 +263,8 @@
email: [email protected]
aliases:
- Jaime RGP
num_commits: 41
- jaimergp
num_commits: 1
first_commit: 2022-01-08 14:56:53
github: jaimergp
- name: Tom Hören
Expand Down Expand Up @@ -323,6 +324,6 @@
github: guimondmm
- name: Daniel Bast
email: [email protected]
num_commits: 10
num_commits: 16
first_commit: 2022-12-08 12:49:40
github: dbast
1 change: 1 addition & 0 deletions .mailmap
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@ Ian Henriksen <[email protected]>
Ilan Schnell <[email protected]> Ilan Schnell <[email protected]>
Isuru Fernando <[email protected]>
Jaime Rodríguez-Guerra <[email protected]> Jaime RGP <[email protected]>
Jaime Rodríguez-Guerra <[email protected]> jaimergp <[email protected]>
Jannis Leidel <[email protected]>
Jean-Luc Stevens <[email protected]> jlstevens <[email protected]>
John Kirkham <[email protected]>
Expand Down
26 changes: 26 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,31 @@
[//]: # (current developments)

## 2023-01-25 3.4.2:
### Enhancements

* Burn-in constructor version into installers to be able to better support faulty installers. (#604 via #626, #630)

### Bug fixes

* Approach `pre_install` scripts more carefully on Windows.
Dummy scripts will not be included unless specified by the installer creator.
NSIS will try to find `cmd.exe` in some expected locations before blindly relying on `PATH`.
(#621 via #622)

### Other

* Switching from print statements to logging. Log levels, filtering, custom formatting strings etc. allow much more verbose and frequent messaging to follow the program flow in case of regular usage and also debugging and development. (#609, #630)
* Add + apply isort via pre-commit (#619)
* Speedup unit tests by factor 5. (#625)
* Add upper conda version bound as with conda >=23.1.0 the local repodata format has changed and `write_repodata()` has to be updated. See #628 for details. (#627)

### Contributors

* @dbast
* @jaimergp



## 2023-01-18 3.4.1:
### Bug fixes

Expand Down
2 changes: 1 addition & 1 deletion constructor/osxpkg.py
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@ def modify_xml(xml_path, info):
background_path = join(OSX_DIR, 'MacInstaller.png')

if background_path:
logger.info("Using background image", background_path)
logger.info("Using background image: %s", background_path)
for key in ("background", "background-darkAqua"):
background = ET.Element(key,
file=background_path,
Expand Down
4 changes: 2 additions & 2 deletions docs/source/howto.md
Original file line number Diff line number Diff line change
Expand Up @@ -69,5 +69,5 @@ Recent constructor versions (>=3.4.2) burn-in their version into created install
The burned-in version can be retrieved in different ways depending on the installer type:

- For `.sh` intallers (via cli): `head $installer.sh | grep "Created by constructor"`
- For `.exe` installers (via Windows Explorer): `$installer.exe` → Properties → Details → Comments
- For `.pkg` installers (via cli on macOS): `xar -xf $installer.pkg -n run_installation.pkg/Scripts; zgrep run_installation.pkg/Scripts "Created by constructor"`
- For `.exe` installers (via Windows Explorer): `$installer.exe` → Properties → Details → Comments, or (via cli) `exiftool $installer.exe`
- For `.pkg` installers (via cli on macOS): `xar -xf $installer.pkg -n run_installation.pkg/Scripts; zgrep -a "Created by constructor" run_installation.pkg/Scripts` or `pkgutil --expand $installer.pkg extracted; grep "Created by constructor" extracted/run_installation.pkg/Scripts/postinstall`
19 changes: 0 additions & 19 deletions news/609-switch-to-logging

This file was deleted.

3 changes: 0 additions & 3 deletions news/619-isort

This file was deleted.

22 changes: 0 additions & 22 deletions news/622-fix-pre-install

This file was deleted.

19 changes: 0 additions & 19 deletions news/625-speedup-test

This file was deleted.

19 changes: 0 additions & 19 deletions news/626-burn-in-version

This file was deleted.

19 changes: 0 additions & 19 deletions news/627-restrict-conda-version

This file was deleted.

0 comments on commit 29ed8bc

Please sign in to comment.