Remove grpc jars in directories other than connect plugin directories#260
Open
Animesh Kumar (akanimesh7) wants to merge 1 commit into
Open
Remove grpc jars in directories other than connect plugin directories#260Animesh Kumar (akanimesh7) wants to merge 1 commit into
Animesh Kumar (akanimesh7) wants to merge 1 commit into
Conversation
|
|
| && rpm --import ${CONFLUENT_PACKAGES_REPO}/archive.key \ | ||
| && printf "[Confluent.dist] \n\ | ||
| && rm -rf /usr/share/java/kafka/grpc-*.jar | ||
| && rm -rf /usr/share/java/confluent-metadata-service/grpc-*.jar |
Member
There was a problem hiding this comment.
Animesh Kumar (@akanimesh7) why not taking a safer approach of investigating why grpc jars end up there, so that we can exclude those jars from the root.
This change is disruptive because it will remove every grpc jars.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On running some of the connectors (spanner sink, pubsub sink and gcp bigtable sink) which package grpc dependencies, we are facing issues starting with CP 7.6.0 release. The detailed stacktrace is
The root cause for this is introduction of conflicting JARs in the
kafkaandconfluent-metadata-servicedirectories.For kafka directory
For confluent-metadata-service directory
These were not present in the previous CP versions. Except for
grpc-context-1.45.1.jarpresent in the kafka directory. But removing it is also seemingly harmless.