Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sat-adaptor [DRAFT PR] #636

Open
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

Shikhar-Srivastava-16
Copy link
Contributor

added previous changes from sat adaptor

@Shikhar-Srivastava-16 Shikhar-Srivastava-16 added the area::sat Related to SAT rules, SAT solvers and the KisSAT solver interface. label Feb 4, 2025
@Shikhar-Srivastava-16 Shikhar-Srivastava-16 self-assigned this Feb 4, 2025
@ozgurakgun
Copy link
Contributor

Thanks @Shikhar-Srivastava-16! I think we don't need solvers/sat at all as a separate crate, since we are depending on the existing rustsat crate. Do you agree?

@Shikhar-Srivastava-16
Copy link
Contributor Author

Thanks @Shikhar-Srivastava-16! I think we don't need solvers/sat at all as a separate crate, since we are depending on the existing rustsat crate. Do you agree?

That would probably be a good idea - I'll move the content to a directory in adaptors. We'll talk in greater detail about this in the next meeting, and we can always roll back the changes later on.

…r in adaptor

changes in cargo.toml to adjust for the change in module structure.
Passes cargo check
Passes cargo build
@ozgurakgun ozgurakgun marked this pull request as ready for review February 7, 2025 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area::sat Related to SAT rules, SAT solvers and the KisSAT solver interface.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants