Skip to content

fix: use RESTRICT for dropping extensions in revert.ts #123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
pyramation wants to merge 1 commit into from
Closed

fix: use RESTRICT for dropping extensions in revert.ts #123

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions packages/core/src/projects/revert.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,10 +60,18 @@ export const revertProject = async (
for (const extension of reversedExtensions) {
try {
if (extensions.external.includes(extension)) {
const msg = `DROP EXTENSION IF EXISTS "${extension}" CASCADE;`;
const msg = `DROP EXTENSION IF EXISTS "${extension}" RESTRICT;`;
log.warn(`⚠️ Dropping external extension: ${extension}`);
log.debug(`> ${msg}`);
await pgPool.query(msg);
try {
await pgPool.query(msg);
} catch (err: any) {
if (err.code === '2BP01') { // dependent_objects_still_exist
log.warn(`⚠️ Cannot drop extension ${extension} due to dependencies, skipping`);
} else {
throw err;
}
}
} else {
const modulePath = resolve(mod.workspacePath, modules[extension].path);
log.info(`📂 Reverting local module: ${extension}`);
Expand Down