Feat/undefined cases

packages/core/__tests__/core/__snapshots__/workspace-extensions-dependency-order.test.ts.snap

@@ -0,0 +1,113 @@
+// Jest Snapshot v1, https://goo.gl/fbAQLP
+
+exports[`getWorkspaceExtensionsInDependencyOrder with complex existing fixtures handles different fixture types consistently 1`] = `
+{
+  "external": [
+    "citext",
+    "plpgsql",
+    "pgcrypto",
+  ],
+  "resolved": [
+    "citext",
+    "plpgsql",
+    "pgcrypto",
+    "my-first",
+    "my-second",
+    "my-third",
+  ],
+}
+`;
+
+exports[`getWorkspaceExtensionsInDependencyOrder with complex existing fixtures returns extensions in dependency order for complex workspace 1`] = `
+{
+  "external": [
+    "plpgsql",
+    "uuid-ossp",
+    "pgcrypto",
+  ],
+  "resolved": [
+    "plpgsql",
+    "uuid-ossp",
+    "pg-utilities",
+    "pg-verify",
+    "pgcrypto",
+    "totp",
+    "utils",
+    "secrets",
+  ],
+}
+`;
+
+exports[`getWorkspaceExtensionsInDependencyOrder with complex existing fixtures verifies dependency ordering properties 1`] = `
+{
+  "external": [
+    "citext",
+    "plpgsql",
+    "pgcrypto",
+  ],
+  "resolved": [
+    "citext",
+    "plpgsql",
+    "pgcrypto",
+    "my-first",
+    "my-second",
+    "my-third",
+  ],
+}
+`;
+
+exports[`getWorkspaceExtensionsInDependencyOrder with existing fixtures handles workspace with minimal modules 1`] = `
+{
+  "external": [
+    "citext",
+    "plpgsql",
+    "pgcrypto",
+  ],
+  "resolved": [
+    "citext",
+    "plpgsql",
+    "pgcrypto",
+    "my-first",
+    "my-second",
+    "my-third",
+  ],
+}
+`;
+
+exports[`getWorkspaceExtensionsInDependencyOrder with existing fixtures returns extensions in dependency order for launchql workspace 1`] = `
+{
+  "external": [
+    "plpgsql",
+    "uuid-ossp",
+    "pgcrypto",
+  ],
+  "resolved": [
+    "plpgsql",
+    "uuid-ossp",
+    "pg-utilities",
+    "pg-verify",
+    "pgcrypto",
+    "totp",
+    "utils",
+    "secrets",
+  ],
+}
+`;
+
+exports[`getWorkspaceExtensionsInDependencyOrder with existing fixtures returns extensions in dependency order for simple-w-tags workspace 1`] = `
+{
+  "external": [
+    "citext",
+    "plpgsql",
+    "pgcrypto",
+  ],
+  "resolved": [
+    "citext",
+    "plpgsql",
+    "pgcrypto",
+    "my-first",
+    "my-second",
+    "my-third",
+  ],
+}
+`;

packages/core/__tests__/core/workspace-extensions-dependency-order.test.ts

@@ -0,0 +1,84 @@
+process.env.LAUNCHQL_DEBUG = 'true';
+
+import { LaunchQLProject } from '../../src/core/class/launchql';
+import { TestFixture } from '../../test-utils';
+
+let fixture: TestFixture;
+
+beforeAll(() => {
+  fixture = new TestFixture('sqitch');
+});
+
+afterAll(() => {
+  fixture.cleanup();
+});
+
+describe('getWorkspaceExtensionsInDependencyOrder', () => {
+  describe('with existing fixtures', () => {
+    it('returns extensions in dependency order for simple-w-tags workspace', () => {
+      const workspacePath = fixture.getFixturePath('simple-w-tags');
+      const project = new LaunchQLProject(workspacePath);
+
+      const result = project.resolveWorkspaceExtensionDependencies();
+      expect(result).toMatchSnapshot();
+    });
+
+    it('returns extensions in dependency order for launchql workspace', () => {
+      const workspacePath = fixture.getFixturePath('launchql');
+      const project = new LaunchQLProject(workspacePath);
+
+      const result = project.resolveWorkspaceExtensionDependencies();
+      expect(result).toMatchSnapshot();
+    });
+
+    it('handles workspace with minimal modules', () => {
+      const workspacePath = fixture.getFixturePath('simple');
+      const project = new LaunchQLProject(workspacePath);
+
+      const result = project.resolveWorkspaceExtensionDependencies();
+      expect(result).toMatchSnapshot();
+
+      expect(result).toHaveProperty('resolved');
+      expect(result).toHaveProperty('external');
+    });
+  });
+
+  describe('with complex existing fixtures', () => {
+    it('returns extensions in dependency order for complex workspace', () => {
+      const workspacePath = fixture.getFixturePath('launchql');
+      const project = new LaunchQLProject(workspacePath);
+
+      const result = project.resolveWorkspaceExtensionDependencies();
+      expect(result).toMatchSnapshot();
+
+      expect(Array.isArray(result.resolved)).toBe(true);
+      expect(Array.isArray(result.external)).toBe(true);
+    });
+
+    it('verifies dependency ordering properties', () => {
+      const workspacePath = fixture.getFixturePath('simple-w-tags');
+      const project = new LaunchQLProject(workspacePath);
+
+      const result = project.resolveWorkspaceExtensionDependencies();
+      expect(result).toMatchSnapshot();
+
+      expect(result).toHaveProperty('resolved');
+      expect(result).toHaveProperty('external');
+      expect(Array.isArray(result.resolved)).toBe(true);
+      expect(Array.isArray(result.external)).toBe(true);
+
+      expect(result.resolved.length).toBeGreaterThanOrEqual(0);
+      expect(result.external.length).toBeGreaterThanOrEqual(0);
+    });
+
+    it('handles different fixture types consistently', () => {
+      const workspacePath = fixture.getFixturePath('simple');
+      const project = new LaunchQLProject(workspacePath);
+
+      const result = project.resolveWorkspaceExtensionDependencies();
+      expect(result).toMatchSnapshot();
+
+      expect(result.resolved.length).toBeGreaterThan(0);
+    });
+  });
+});

packages/core/__tests__/projects/deployment-scenarios.test.ts

@@ -0,0 +1,51 @@
+process.env.LAUNCHQL_DEBUG = 'true';
+
+import { TestDatabase } from '../../test-utils';
+import { CoreDeployTestFixture } from '../../test-utils/CoreDeployTestFixture';
+
+describe('Deployment Scenarios with Undefined Targets', () => {
+  let fixture: CoreDeployTestFixture;
+  let db: TestDatabase;
+
+  beforeEach(async () => {
+    fixture = new CoreDeployTestFixture('sqitch', 'simple-w-tags');
+    db = await fixture.setupTestDatabase();
+  });
+
+  afterEach(async () => {
+    await fixture.cleanup();
+  });
+
+  test('handles undefined target scenarios for deploy, revert, and verify operations', async () => {
+    await fixture.deployModule(undefined as any, db.name, ['sqitch', 'simple-w-tags']);
+
+    expect(await db.exists('schema', 'metaschema')).toBe(true);
+    expect(await db.exists('table', 'metaschema.customers')).toBe(true);
+
+    await expect(
+      fixture.verifyModule(undefined as any, db.name, ['sqitch', 'simple-w-tags'])
+    ).resolves.not.toThrow();
+
+    await fixture.revertModule(undefined as any, db.name, ['sqitch', 'simple-w-tags']);
+
+    expect(await db.exists('schema', 'metaschema')).toBe(false);
+    expect(await db.exists('table', 'metaschema.customers')).toBe(false);
+
+    await fixture.deployModule('my-third', db.name, ['sqitch', 'simple-w-tags']);
+
+    expect(await db.exists('schema', 'metaschema')).toBe(true);
+    expect(await db.exists('table', 'metaschema.customers')).toBe(true);
+
+    await fixture.revertModule('my-first:@v1.0.0', db.name, ['sqitch', 'simple-w-tags']);
+
+    expect(await db.exists('schema', 'metaschema')).toBe(false);
+    expect(await db.exists('table', 'metaschema.customers')).toBe(false);
+
+    await fixture.deployModule(undefined as any, db.name, ['sqitch', 'simple-w-tags']);
+
+    expect(await db.exists('schema', 'metaschema')).toBe(true);
+    expect(await db.exists('table', 'metaschema.customers')).toBe(true);
+
+    await fixture.verifyModule(undefined as any, db.name, ['sqitch', 'simple-w-tags']);
+  });
+});

packages/core/__tests__/projects/revert-truncation-scenarios.test.ts

@@ -0,0 +1,91 @@
+process.env.LAUNCHQL_DEBUG = 'true';
+
+import { TestDatabase } from '../../test-utils';
+import { CoreDeployTestFixture } from '../../test-utils/CoreDeployTestFixture';
+
+describe('Revert Truncation Scenarios', () => {
+  let fixture: CoreDeployTestFixture;
+  let db: TestDatabase;
+
+  beforeEach(async () => {
+    fixture = new CoreDeployTestFixture('sqitch', 'simple-w-tags');
+    db = await fixture.setupTestDatabase();
+  });
+
+  afterAll(async () => {
+    await fixture.cleanup();
+  });
+
+  test('deploys my-third and reverts to my-first with toChange - should revert all dependent modules', async () => {
+    await fixture.deployModule('my-third', db.name, ['sqitch', 'simple-w-tags']);
+
+    expect(await db.exists('schema', 'myapp')).toBe(true);        // my-first
+    expect(await db.exists('table', 'myapp.products')).toBe(true); // my-first @v1.1.0
+    expect(await db.exists('schema', 'otherschema')).toBe(true);   // my-second
+    expect(await db.exists('table', 'otherschema.users')).toBe(true); // my-second @v2.0.0
+    expect(await db.exists('schema', 'metaschema')).toBe(true);    // my-third
+    expect(await db.exists('table', 'metaschema.customers')).toBe(true); // my-third
+
+    await fixture.revertModule('my-first:@v1.0.0', db.name, ['sqitch', 'simple-w-tags']);
+
+    expect(await db.exists('schema', 'metaschema')).toBe(false);
+    expect(await db.exists('table', 'metaschema.customers')).toBe(false);
+    expect(await db.exists('schema', 'otherschema')).toBe(false);
+    expect(await db.exists('table', 'otherschema.users')).toBe(false);
+
+    expect(await db.exists('schema', 'myapp')).toBe(true);
+    expect(await db.exists('table', 'myapp.users')).toBe(true);
+    expect(await db.exists('table', 'myapp.products')).toBe(false); // @v1.1.0 change reverted
+  });
+
+  test('deploys my-third and reverts my-second without toChange - should use module-specific resolution', async () => {
+    await fixture.deployModule('my-third', db.name, ['sqitch', 'simple-w-tags']);
+
+    expect(await db.exists('schema', 'metaschema')).toBe(true);
+    expect(await db.exists('table', 'metaschema.customers')).toBe(true);
+    expect(await db.exists('schema', 'otherschema')).toBe(true);
+    expect(await db.exists('table', 'otherschema.users')).toBe(true);
+
+    await fixture.revertModule('my-second', db.name, ['sqitch', 'simple-w-tags']);
+
+    expect(await db.exists('schema', 'otherschema')).toBe(false);
+    expect(await db.exists('table', 'otherschema.users')).toBe(false);
+
+    expect(await db.exists('schema', 'myapp')).toBe(true);
+    expect(await db.exists('table', 'myapp.products')).toBe(true);
+
+    expect(await db.exists('schema', 'metaschema')).toBe(false);
+  });
+
+  test('null name with cwd inside my-second calling revert - should revert all modules', async () => {
+    await fixture.deployModule('my-third', db.name, ['sqitch', 'simple-w-tags']);
+
+    expect(await db.exists('schema', 'metaschema')).toBe(true);
+    expect(await db.exists('schema', 'otherschema')).toBe(true);
+    expect(await db.exists('schema', 'myapp')).toBe(true);
+
+    await fixture.revertModule(undefined as any, db.name, ['sqitch', 'simple-w-tags']);
+
+    expect(await db.exists('schema', 'metaschema')).toBe(false);
+    expect(await db.exists('schema', 'otherschema')).toBe(false);
+    expect(await db.exists('schema', 'myapp')).toBe(false);
+  });
+
+  test('verifies workspace-wide resolution with toChange ensures proper dependency handling', async () => {
+
+    await fixture.deployModule('my-third', db.name, ['sqitch', 'simple-w-tags']);
+
+    expect(await db.exists('schema', 'myapp')).toBe(true);        // my-first
+    expect(await db.exists('schema', 'otherschema')).toBe(true);   // my-second  
+    expect(await db.exists('schema', 'metaschema')).toBe(true);    // my-third
+
+    await fixture.revertModule('my-first:@v1.0.0', db.name, ['sqitch', 'simple-w-tags']);
+
+    expect(await db.exists('schema', 'metaschema')).toBe(false);
+    expect(await db.exists('schema', 'otherschema')).toBe(false);
+
+    expect(await db.exists('schema', 'myapp')).toBe(true);
+    expect(await db.exists('table', 'myapp.users')).toBe(true);
+    expect(await db.exists('table', 'myapp.products')).toBe(false); // @v1.1.0 change reverted
+  });
+});

packages/core/__tests__/resolution/dependency-resolution-basic.test.ts

@@ -1,5 +1,5 @@
 import { listModules } from '../../src/modules/modules';
-import { extDeps,resolveDependencies } from '../../src/resolution/deps';
+import { resolveExtensionDependencies, resolveDependencies } from '../../src/resolution/deps';
 import { TestFixture } from '../../test-utils';
 
 let fixture: TestFixture;
@@ -47,7 +47,7 @@ it('sqitch package dependencies [simple/3rd]', async () => {
 it('launchql project extensions dependencies', async () => {
   const modules = listModules(fixture.getFixturePath('launchql'));
 
-  const utils = await extDeps('utils', modules);
+  const utils = await resolveExtensionDependencies('utils', modules);
   expect(utils).toEqual({
     external: ['plpgsql', 'uuid-ossp', 'pgcrypto'],
     resolved: [
@@ -61,7 +61,7 @@ it('launchql project extensions dependencies', async () => {
     ]
   });
 
-  const secrets = await extDeps('secrets', modules);
+  const secrets = await resolveExtensionDependencies('secrets', modules);
   expect(secrets).toEqual({
     external: ['plpgsql', 'uuid-ossp', 'pgcrypto'],
     resolved: [
@@ -75,7 +75,7 @@ it('launchql project extensions dependencies', async () => {
     ]
   });
 
-  const totp = await extDeps('totp', modules);
+  const totp = await resolveExtensionDependencies('totp', modules);
   expect(totp).toEqual({
     external: ['plpgsql', 'uuid-ossp', 'pgcrypto'],
     resolved: [