core(migrate): add toUnqualifiedLocal method for local tracking guard #224
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add private toUnqualifiedLocal method to LaunchQLMigrate class - Enforces local package scope for deployed/skipped changes - Throws error on cross-package changes to prevent silent bugs - Update deploy and revert methods to use centralized logic - Add test to verify functionality Co-Authored-By: Dan Lynch <[email protected]>
Contributor
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
- Remove type annotations from mock function parameters - Add password field to PgConfig object - Use 'as any' type assertions for LaunchQLMigrate constructor and deploy method Co-Authored-By: Dan Lynch <[email protected]>
…cal-tracking-guard test Co-Authored-By: Dan Lynch <[email protected]>
… in local-tracking-guard test - Replace MigrateTestFixture with jest.mock approach following tag-fallback.test.ts pattern - Mock pg-cache and transaction utilities to avoid requiring PostgreSQL database - Add direct test of toUnqualifiedLocal method for cross-package error handling - Keep existing TypeScript type annotations for strict compilation - Both test cases now pass without database dependencies Co-Authored-By: Dan Lynch <[email protected]>
…cking - Replace jest.mock approach with MigrateTestFixture for proper pg-env configuration - Use fixture.setupTestDatabase() which calls getPgEnvOptions() for database config - Follow established testing patterns from basic-deployment.test.ts - Add proper beforeEach/afterEach hooks for setup and cleanup - Both test cases now work with real PostgreSQL database via pg-env Co-Authored-By: Dan Lynch <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
core(migrate): add toUnqualifiedLocal method for local tracking guard
Summary
Adds a private
toUnqualifiedLocalmethod to theLaunchQLMigrateclass that enforces local package scope for deployed/skipped change tracking. This centralizes logic that was previously duplicated in multiple locations and adds proper error handling for cross-package changes.Key changes:
toUnqualifiedLocalprivate method that validates package scope and extracts local change namesReview & Testing Checklist for Human
This is a medium-risk change affecting critical deployment logic. Please verify:
packages/core/__tests__/migrate/local-tracking-guard.test.tspasses and covers the right scenariostoUnqualifiedLocalhandles all edge cases correctly (empty strings, multiple colons, etc.)Notes
devin/1756430832-local-tracking-guardto create a fresh implementationLink to Devin run: https://app.devin.ai/sessions/93a117783417440999ebee209a464e9d
Requested by: Dan Lynch (@pyramation)