Add interactive --to flag for CLI revert command #229
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add getDeployedModules() method to query launchql_migrate.changes table - Make resolveWorkspaceExtensionDependencies() async with optional deployment filtering - Update revert() method to filter workspace extensions by deployment status - Fix test file to handle async resolveWorkspaceExtensionDependencies() calls - Add comprehensive REVERT.md documentation This optimization prevents recursive revert from processing undeployed modules, significantly improving performance for large workspaces. Co-Authored-By: Dan Lynch <[email protected]>
- Add selectDeployedChange() function for two-step selection - Query deployed packages using LaunchQLMigrate.status() - Query deployed changes using LaunchQLMigrate.getDeployedChanges() - Maintain backward compatibility with existing --to string usage - Add autocomplete prompts for package and change selection - Update usage text with interactive examples - Handle graceful fallback when database is unavailable Co-Authored-By: Dan Lynch <[email protected]>
Contributor
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
- Use target database parameter instead of default database
- Follow same pattern as deploy command with getPgEnvOptions({ database })
- Ensures interactive --to flag queries the correct target database
Co-Authored-By: Dan Lynch <[email protected]>
- Add optional preselectedPackage parameter to selectDeployedChange() - Skip package selection when package already selected via --package or recursive mode - Show only changes for preselected package to refine selection - Maintain two-step selection (package then change) when no package preselected - Improve user experience by reducing unnecessary prompts Co-Authored-By: Dan Lynch <[email protected]>
- Update selectDeployedChange() to accept and use argv parameter - Use 'package' and 'change' as question names to match CLI flags - Pass argv to prompter.prompt() calls for automatic CLI argument passthrough - Override existing package selection with scoped deployed packages when using --to - Remove manual preselection logic in favor of inquirer's built-in handling - Follow established pattern from deploy command and other CLI commands Co-Authored-By: Dan Lynch <[email protected]>
- Create shared selectDeployedChange and selectDeployedPackage utilities - Fix revert command to use scoped deployed packages when --package not supplied - Add interactive --to flag functionality to verify command - Both commands now use database-aware package selection with workspace fallback - Follow established argv passthrough patterns to prevent duplicate prompts Co-Authored-By: Dan Lynch <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add interactive --to flag for CLI revert command + Optimize recursive revert performance
Summary
This PR implements two related improvements to LaunchQL's revert functionality:
1. Performance Optimization for Recursive Reverts
resolveWorkspaceExtensionDependencies()to optionally filter by deployed modules using database queriesgetDeployedModules()helper method that queries thelaunchql_migrateschema to determine which packages are actually deployed2. Interactive CLI --to Flag Enhancement
--toflag is provided without a value (lql revert --to)LaunchQLMigrate.status()andgetDeployedChanges()for real-time database querying--tousageReview & Testing Checklist for Human
lql revert --towith deployed changes in database and verify two-step selection works correctly--to <string>usage still works and non-interactive revert commands unchangedas anycasting which could cause runtime errors if prompter response structure changesNotes
Risk Areas:
resolveWorkspaceExtensionDependencies()is now async and affects multiple callsites - could break untested code pathsPerformance Impact: The optimization should significantly improve recursive revert performance in large workspaces, but adds database queries that could potentially slow down other operations.
Link to Devin run: https://app.devin.ai/sessions/a5cdd2aebe714b9d835b800ce9f02915
Requested by: @pyramation