fix: comment out status/registration console.warn in graphile-postgis #449
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
devin-ai-integration
bot
changed the title
devin-ai-integration
bot
force-pushed
the
devin/1766533977-remove-console-logs
branch
from
3e98a9f to
b69f8ab
Compare
Removes debug/informational console output from: - graphile-postgis: PostgisRegisterTypesPlugin, PostgisExtensionDetectionPlugin, Postgis_GeometryCollection_GeometriesPlugin - graphile-simple-inflector - graphile-plugin-connection-filter: PgConnectionArgFilterBackwardRelationsPlugin Fixes constructive-io/constructive-planning#409 Co-Authored-By: Dan Lynch <[email protected]>
- Comment out (not delete) status/registration messages in PostgisRegisterTypesPlugin.ts: - 'PostGIS plugin enabled' - 'Getting type...' debug info - 'Registering handler for...' messages - Restore legitimate warnings inside if statements: - PostgisExtensionDetectionPlugin: 'PostGIS extension not found' - Postgis_GeometryCollection_GeometriesPlugin: 'Unexpectedly couldn't find the interface' - graphile-simple-inflector: config hint warning - graphile-plugin-connection-filter: config recommendation warning Co-Authored-By: Dan Lynch <[email protected]>
devin-ai-integration
bot
force-pushed
the
devin/1766533977-remove-console-logs
branch
from
b69f8ab to
9bb1bc1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Comments out debug and status
console.warnstatements inPostgisRegisterTypesPlugin.tsthat were polluting test output and consumer logs.Changes:
graphile-postgis/src/PostgisRegisterTypesPlugin.ts:'PostGIS plugin enabled''Getting ${type.name} type...'debug info'Registering handler for ${GEOGRAPHY_TYPE.id}''Registering handler for ${GEOMETRY_TYPE.id}'Preserved (no changes):
Fixes constructive-io/projects-issues#409
Updates since last revision
Per feedback, changed approach from deleting console.warn statements to commenting them out. Restored files with legitimate warnings (those inside if statements) to their original state.
Review & Testing Checklist for Human
pnpm testingraphile-postgisto verify no regressionsTest plan: Run the graphile-postgis tests to confirm PostGIS functionality still works correctly.
Notes