Fix exports/meta #477
Merged
Fix exports/meta #477
+270
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-Authored-By: Dan Lynch <[email protected]>
- Fix table name from 'database_extensions' (plural) to 'database_extension' (singular) - Add missing queryAndParse call for 'field' table in collections_public - Add unit tests to validate export-meta config structure Co-Authored-By: Dan Lynch <[email protected]>
- Tests exportMeta function with proper table names - Verifies database_extension (singular) is used correctly - Tests that field table is queried - Validates exported SQL contains expected data
The test exposed a pre-existing compatibility issue with csv-to-pg library (ast.ResTarget is not a function). The static config validation tests in pgpm/core/__tests__/export/ already verify the bug fixes. This can be revisited once the csv-to-pg compatibility issue is resolved.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.