Skip to content

Conversation

@pyramation
Copy link
Contributor

Summary

Simplifies the linting setup to follow the recommended pattern: Prettier handles all formatting, ESLint handles only correctness and import sorting.

ESLint changes:

  • Removed all formatting rules (indent, quotes, semi, comma-dangle, etc.) - Prettier handles these
  • Removed unused-imports plugin
  • Removed TypeScript rule overrides - using recommended defaults
  • Removed env block
  • Changed import-sort rules from warnings to errors

Prettier changes:

  • trailingComma: "es5" → "all"
  • Added explicit printWidth: 80
  • Removed redundant defaults (tabWidth, useTabs, jsxSingleQuote)

Review & Testing Checklist for Human

  • Verify env removal is safe: The removal of env: { node: true, jest: true, browser: true } may cause no-undef errors for globals like process, describe, it. Run pnpm lint on a few packages to confirm no false positives
  • Confirm TypeScript defaults are acceptable: Removing overrides means @typescript-eslint/no-explicit-any becomes a warning and @typescript-eslint/no-unused-vars uses default patterns - verify this is desired
  • Test trailingComma: "all" impact: This will add trailing commas to function parameters when Prettier runs - confirm this style is acceptable

Test plan: Run npx eslint packages/cli/src/index.ts to verify ESLint works without errors on the config itself.

Notes

This PR contains config changes only. A follow-up PR will apply the actual linting fixes to the codebase.

Link to Devin run: https://app.devin.ai/sessions/1a95a9e3b5994325aeffe5ae1289aa0a
Requested by: Dan Lynch ([email protected]) / @pyramation

@devin-ai-integration
Copy link
Contributor

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR. Add '(aside)' to your comment to have me ignore it.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment and CI monitoring

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants