chore: remove apiExtensions and database_extension references #654
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
Remove all references to the removed extension tables: - Remove apiExtensions from apiSelect and normalizeApiRecord in gql.ts - Remove database_extension and api_extensions configs from export-meta.ts - Remove database_extension and api_extensions from tableOrder in export-migrations.ts - Update tests to remove extension table references
devin-ai-integration
bot
force-pushed
the
devin/1769235227-remove-api-extensions
branch
from
23dc3a2 to
a70d605
Compare
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Removes all references to the
apiExtensions,database_extension, andapi_extensionstables from the constructive repo. This is a follow-up to constructive-db PR #434 which removed these unused extension tables from the database schema.Key changes:
apiExtensionsfrom the GraphQL API select andnormalizeApiRecordfunction - schema names now come solely fromschemasByApiSchemaApiIdAndSchemaIddatabase_extensionandapi_extensionsconfigs from the pgpm export utilitiesReview & Testing Checklist for Human
apiExtensionsfor schema name resolution (theschemasByApiSchemaApiIdAndSchemaIdrelation should be the canonical source)Updates since last revision
Notes
This PR is part of a cleanup effort to remove extension-tracking tables that were designed but never implemented. The tables existed in the schema but no application logic ever populated or read from them.
Requested by: Dan Lynch (@pyramation)
Link to Devin run: https://app.devin.ai/sessions/89938c05148d4fd1953769e7af899382