fix(graphile-plugin-connection-filter-postgis): update version check to support ^3.0.0 #655
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to support ^3.0.0 The runtime version check was requiring graphile-plugin-connection-filter@^2.0.0 but [email protected] depends on graphile-plugin-connection-filter@^3.0.0. This caused a runtime error when using the updated graphile-settings package.
Contributor
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Updates the runtime version check in
graphile-plugin-connection-filter-postgisto requiregraphile-plugin-connection-filter@^3.0.0instead of^2.0.0.This fix is needed because
[email protected]depends ongraphile-plugin-connection-filter@^3.0.0, and the old version check was causing runtime errors:Review & Testing Checklist for Human
[email protected](this PR only updates the version check, not the actual compatibility)Notes
This was discovered while upgrading dependencies in constructive-db PR #435.
Link to Devin run: https://app.devin.ai/sessions/52a59f63cea74493bcb0d97f67422e8d
Requested by: Dan Lynch (@pyramation)