Skip to content

Fix lifecycle and ControllerUnpublishVolume description #533

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Fix lifecycle and ControllerUnpublishVolume description #533

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
69 changes: 36 additions & 33 deletions spec.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,19 +165,20 @@ capability.

```
CreateVolume +------------+ DeleteVolume
+------------->| CREATED +--------------+
| +---+----^---+ |
| Controller | | Controller v
+++ Publish | | Unpublish +++
|X| Volume | | Volume | |
+-+ +---v----+---+ +-+
| NODE_READY |
+---+----^---+
Node | | Node
Publish | | Unpublish
Volume | | Volume
+---v----+---+
| PUBLISHED |
+------------->| CREATED +-------------------------+
| | <---------+ |
| +---+----^---+ | |
| Controller | | Controller | v
+++ Publish | | Unpublish | +++
|X| Volume | | Volume | | |
+-+ +---v----+---+ | Controller +-+
| NODE_READY | | Unpublish
+---+----^---+ | Volume
Node | | Node | (forced)
Publish | | Unpublish |
Volume | | Volume |
+---v----+---+ |
| PUBLISHED +---------+
+------------+

Figure 5: The lifecycle of a dynamically provisioned volume, from
Expand All @@ -186,25 +187,26 @@ creation to destruction.

```
CreateVolume +------------+ DeleteVolume
+------------->| CREATED +--------------+
| +---+----^---+ |
| Controller | | Controller v
+++ Publish | | Unpublish +++
|X| Volume | | Volume | |
+-+ +---v----+---+ +-+
| NODE_READY |
+---+----^---+
Node | | Node
Stage | | Unstage
Volume | | Volume
+---v----+---+
| VOL_READY |
+---+----^---+
Node | | Node
Publish | | Unpublish
Volume | | Volume
+---v----+---+
| PUBLISHED |
+------------->| CREATED +--------------------------+
| | <--------+ |
| +---+----^---+ | |
| Controller | | Controller | v
+++ Publish | | Unpublish | +++
|X| Volume | | Volume | | |
+-+ +---v----+---+ | Controller +-+
| NODE_READY | | Unpublish
+---+----^---+ | Volume
Node | | Node | (forced)
Stage | | Unstage |
Volume | | Volume |
+---v----+---+ |
| VOL_READY +--------+
+---+----^---+ |
Node | | Node |
Publish | | Unpublish |
Volume | | Volume |
+---v----+---+ |
| PUBLISHED +--------+
+------------+

Figure 6: The lifecycle of a dynamically provisioned volume, from
Expand Down Expand Up @@ -1318,7 +1320,8 @@ The CO MUST implement the specified error recovery behavior when it encounters t

Controller Plugin MUST implement this RPC call if it has `PUBLISH_UNPUBLISH_VOLUME` controller capability.
This RPC is a reverse operation of `ControllerPublishVolume`.
It MUST be called after all `NodeUnstageVolume` and `NodeUnpublishVolume` on the volume are called and succeed.
Basically, it MUST be called after all `NodeUnstageVolume` and `NodeUnpublishVolume` on the volume are called and succeed.
When control plane retry the `NodeUnstage` / `NodeUnpublish` but it can't reach the node(for example node shut down due to a hardware failure or a software problem), it proceeds on to `ControllerUnpublish`.
The Plugin SHOULD perform the work that is necessary for making the volume ready to be consumed by a different node.
The Plugin MUST NOT assume that this RPC will be executed on the node where the volume was previously used.

Expand Down