KEP-5943: Introducing Snapshot Topology - #606
Conversation
|
/assign @bswartz |
mdzraf
changed the title
|
Do we need to add some constraints for TopologyRequirement in CreateVolumeRequest if VolumeContentSource is a Snapshot? |
We can discuss this but we will already be enforcing it at provisioning time via the external-provisioner and the custom scheduler plugin. |
| @@ -2037,7 +2070,7 @@ The CO MUST implement the specified error recovery behavior when it encounters t | |||
| |-----------|-----------|-------------|-------------------| | |||
| | Snapshot already exists but is incompatible | 6 ALREADY_EXISTS | Indicates that a snapshot corresponding to the specified snapshot `name` already exists but is incompatible with the specified `volume_id`. | Caller MUST fix the arguments or use a different `name` before retrying. | | |||
There was a problem hiding this comment.
13 Is not the right number for RESOURCE_EXHAUSTED this is fixed in #605, hence why the number change here as well instead of a separate entry.
|
lgtm |
|
@mdzraf can you please
|
|
Hi @saad-ali , I'ver signed the CLA and sent the email to the CSI Approvers list and CC'd you on it, and PR is rebased. Thank you! |
|
Confirmed CLA, thanks! Can you check why the build might be failing here? |
|
Hi @saad-ali , I've fixed it now, should pass. |
|
Thank you. /lgtm |
5 participants
What type of PR is this?
Introducing Snapshot Topology to CSI Spec.
What this PR does / why we need it:
This PR is part of the changes necessary for kubernetes/enhancements#5944
Special notes for your reviewer:
Does this PR introduce an API-breaking change?: