api,adaptation,generate: allow adjusting linux net devices #157
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
klihub
force-pushed
the
devel/linux-net-devices
branch
from
df6df04 to
02f0b68
Compare
|
❤️ |
klihub
force-pushed
the
devel/linux-net-devices
branch
from
02f0b68 to
d886c51
Compare
klihub
force-pushed
the
devel/linux-net-devices
branch
2 times, most recently
from
df21d77 to
20533ae
Compare
klihub
force-pushed
the
devel/linux-net-devices
branch
from
20533ae to
6e14a15
Compare
|
/cc @aojea @tao12345666333 Here is the draft PR proposal #180 was asking for. |
aojea
reviewed
Jun 25, 2025
aojea
reviewed
Jun 25, 2025
aojea
reviewed
Jun 25, 2025
|
This is fantastic @klihub , can we undraft it for final review |
klihub
force-pushed
the
devel/linux-net-devices
branch
from
6e14a15 to
a03dcca
Compare
We can try to do that to get it reviewed. @mikebrow WDYT? But I think we won't be able to get this merged before the necessary new bits in runtime-spec gets behind a tag. Both CRI-O and containerd main/HEAD is at [email protected] and I think we usually tend to stick to a tagged version in both even in main. |
|
ok, that is fair |
|
Fixes: #180 |
Point opencontainers/runtime-spec to a (yet untagged) version with support for linux net device injection. Signed-off-by: Krisztian Litkey <[email protected]>
Signed-off-by: Krisztian Litkey <[email protected]>
We still have support for the deprecated OCI Prestart hook. Add ignore rule for the related linting error. Signed-off-by: Krisztian Litkey <[email protected]>
Allow adding and removing container linux net devices. Signed-off-by: Krisztian Litkey <[email protected]>
Signed-off-by: Krisztian Litkey <[email protected]>
klihub
force-pushed
the
devel/linux-net-devices
branch
from
a03dcca to
a999d9b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow plugins to adjust linux net devices.
Notes:
This PR is marked a draft since it uses an untagged opencontainers/runtime-spec version v1.2.2-0.20250401095657-e935f995dd67. Once a new version is tagged, we can mark this PR ready for review. Testing this requires
runcwith support forLinuxNetDeviceinjection, @aojea has a pending PR