Skip to content

Comments

non-core subproject status changes#86

Merged
mikebrow merged 2 commits intocontainerd:mainfrom
mikebrow:remove-governance
Nov 3, 2023
Merged

non-core subproject status changes#86
mikebrow merged 2 commits intocontainerd:mainfrom
mikebrow:remove-governance

Conversation

@mikebrow
Copy link
Member

@mikebrow mikebrow commented Mar 21, 2022

Address #36

Merge Approval Requires 2/3 of the current committers (8 votes)

Signed-off-by: Mike Brown brownwm@us.ibm.com

Signed-off-by: Mike Brown <brownwm@us.ibm.com>
@mikebrow mikebrow force-pushed the remove-governance branch from 6dd060d to b25203a Compare March 21, 2022 18:41
@mikebrow mikebrow changed the title non-core subproject status changes [wip] non-core subproject status changes Mar 22, 2022
Co-authored-by: Samuel Karp <me@samuelkarp.com>
Signed-off-by: Mike Brown <brownwm@us.ibm.com>
@mikebrow mikebrow changed the title [wip] non-core subproject status changes non-core subproject status changes Feb 6, 2023
Copy link
Member

@dims dims left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

raise objections and cast their vote. Project changes of this type must be approved
by 2/3 of the current core committers and core committers are encouraged to consider the opinions and objections of the existing non-core project maintainers.

Project status changes do not automatically change the status of any non-core project maintainers. Project status change proposals may be accompanied by additional proposals to change individual maintainer status, subject to the existing rules set forth in this document.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: wrapping is not right here

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah md doesn't care, the view gets updated when it is loaded.. more a convention to insert extra line breaks or not

Copy link
Member

@fuweid fuweid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AkihiroSuda AkihiroSuda requested review from estesp and kevpar November 3, 2023 06:59
@mikebrow mikebrow merged commit 428e1cf into containerd:main Nov 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants