-
Notifications
You must be signed in to change notification settings - Fork 178
fix(kiali): Tool names with prefix kiali_ #471
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Alberto Gutierrez <[email protected]>
|
cc @manusa |
| - The server uses your existing Kubernetes credentials (from kubeconfig or in-cluster) to set a bearer token for Kiali calls. | ||
| - If you pass an HTTP Authorization header to the MCP HTTP endpoint, that is not required for Kiali; Kiali calls use the server's configured token. | ||
|
|
||
| ### Available tools (initial) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@aljesusg is there a reason for getting rid of all the tool docs here?
If we want to de-duplicate the tool docs, maybe we can link to the section of the README which describes these tools from this file?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was actually going to try that :) I wasn't aware Alberto had removed the docs already.
Let me take care of adding the link in a different PR, I want to see if I can create a tags with names that can be linked and expand the collapsed section or at least point the user exactly to the collapsed section summary
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are some duplicates in the README, so I can update the documentation script for the rest of the tools if you want and keep the methods here.
It makes more sense to include a link from the README to the toolset documentation instead of duplicating the information.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did some changes in docs for toolsets out the "core"
Signed-off-by: Alberto Gutierrez <[email protected]>
Fix #467
Add prefix kiali_ to all tools related with Kiali