feat(config)!: consolidate custom config parsing into config.Extended #475
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Hi @Cali0707 Addressed the comments regarding ExtendedConfigRegistry and making it private. I didn't change #475 (comment) yet. |
manusa
force-pushed
the
feat/extended-config
branch
from
e99ef87 to
5000e9e
Compare
Signed-off-by: Marc Nuri <[email protected]>
Signed-off-by: Marc Nuri <[email protected]>
manusa
force-pushed
the
feat/extended-config
branch
from
5000e9e to
f47e6ff
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #470
This might imply breaking changes downstream if there are references to the interfaces.
I think the breaking changes tradeoff is OK because there is now a single simple config.Extended interface which avoids code duplication.
This will also allow to better reuse the pattern for other config extensions if needed.