feat(kubernetes): public new manager to enable external providers #482
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to allow third parties to build their own cluster providers, I'd like to propose a very small change to make the
Managerinitialization functionnewManagerpublic. This allows people to easily extend the upstream package without having to fork it.Currently, we can create our own implementation of
Providerand a register a provider configuration, but the provider implementation itself needs to be able to initializeManagers for each cluster it wants to use, which is impossible since only theNewInClusterManagerandNewKubeconfigManagerfunctions are public.A super simple example would look like:
pkg/custom_config.go
pkg/custom_provider.go
main.go
config.toml