Skip to content

Conversation

ScrewTSW
Copy link
Member

What does this PR do?

  • Adds new approach to running tests based on ai.json
  • Fixes model download timeouts inconsistency

Screenshot / video of UI

What issues does this PR fix or reference?

Closes #3333

How to test this PR?

@ScrewTSW ScrewTSW requested review from benoitf, jeffmaury and a team as code owners July 30, 2025 13:42
@ScrewTSW ScrewTSW changed the title 3333 tests based on ai json poc Switch test run to ai-json parsed set of applications Jul 30, 2025
Copy link
Collaborator

@jeffmaury jeffmaury left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments

@cbr7
Copy link
Contributor

cbr7 commented Jul 31, 2025

I'm not sure I understand what this PR is about? What is in the ai.json file that is being read?

@ScrewTSW
Copy link
Member Author

I'm not sure I understand what this PR is about? What is in the ai.json file that is being read?

All of the available inference servers, models and demo apps

@odockal
Copy link
Contributor

odockal commented Aug 1, 2025

This just creates objects with models, services, etc. It does not yet uses them.?

@cbr7
Copy link
Contributor

cbr7 commented Aug 1, 2025

I'm with @odockal on this, the data doesn't seem to be getting used for anything currently.

Also, what is the end goal of the data that will be read from the file? What should it be used for?

@ScrewTSW ScrewTSW force-pushed the 3333-tests-based-on-ai-json-poc branch from f9e9224 to b27dfd2 Compare August 1, 2025 11:19
@ScrewTSW
Copy link
Member Author

ScrewTSW commented Aug 1, 2025

This just creates objects with models, services, etc. It does not yet uses them.?

good catch, not sure how, but it slipped out when I was rewriting it from a diff

@ScrewTSW ScrewTSW marked this pull request as draft August 1, 2025 11:20
@ScrewTSW ScrewTSW force-pushed the 3333-tests-based-on-ai-json-poc branch 3 times, most recently from bca3d93 to 7b50dec Compare August 7, 2025 11:46
@ScrewTSW ScrewTSW force-pushed the 3333-tests-based-on-ai-json-poc branch from 7b50dec to 6ed26ef Compare August 20, 2025 14:27
@ScrewTSW ScrewTSW force-pushed the 3333-tests-based-on-ai-json-poc branch from 6ed26ef to f952429 Compare September 1, 2025 11:00
@ScrewTSW ScrewTSW marked this pull request as ready for review September 1, 2025 11:00
@ScrewTSW ScrewTSW force-pushed the 3333-tests-based-on-ai-json-poc branch 2 times, most recently from 242e3f6 to 84b1845 Compare September 2, 2025 10:52
Copy link
Contributor

@odockal odockal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not have review like itself atm. It is a breaking change, we have discussed maybe even better approach to start with models first aside of running recipes which "contains" almost identical e2e functionality we might also cover individually (download model + test service is also done when running whole recipe, etc).
I am also waiting for PR check to pass reliably.
BUT. It is quite great to see the amount of tests now being run vs. before
image

before:
Screenshot_20250904_163521

Let's proceed with the PR. and talk about possible follow ups.

@ScrewTSW ScrewTSW marked this pull request as draft September 5, 2025 11:20
@ScrewTSW ScrewTSW force-pushed the 3333-tests-based-on-ai-json-poc branch 2 times, most recently from e810ff8 to 805007b Compare September 8, 2025 05:45
@ScrewTSW ScrewTSW force-pushed the 3333-tests-based-on-ai-json-poc branch from 805007b to 2e40274 Compare September 8, 2025 06:25
@ScrewTSW ScrewTSW marked this pull request as ready for review September 8, 2025 07:10
@ScrewTSW
Copy link
Member Author

ScrewTSW commented Sep 8, 2025

@odockal fully passing now, runtime 34 minutes pr-check
Screenshot_20250908_091017
Screenshot_20250908_091029
e2e-test-main
Screenshot_20250908_094923
Screenshot_20250908_094942
passed on Windows too, but it's painfully slow.
the runner section on Azure took 1 hour 8 minutes
Screenshot_20250908_143320

Copy link
Contributor

@danivilla9 danivilla9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I can't find anything to improve. My test run on a windows machine timed out when trying to download a model, but I see that you managed to run them properly on the CI, so I suppose it's some setup issue on my end.
One tiny nitpick, any reason not to use states.ts from the PD core? Not sure if it's possible to do it from an extension repo, but I think it should.

Copy link
Contributor

@bmahabirbu bmahabirbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! Id like to be a part of the conversation for enhancing the ai lab tests as well

@ScrewTSW
Copy link
Member Author

ScrewTSW commented Sep 9, 2025

LGTM, I can't find anything to improve. My test run on a windows machine timed out when trying to download a model, but I see that you managed to run them properly on the CI, so I suppose it's some setup issue on my end. One tiny nitpick, any reason not to use states.ts from the PD core? Not sure if it's possible to do it from an extension repo, but I think it should.

Model download speeds can fluctuate a lot indeed, it's just something that seems to be a limitation of huggingface.
Thank you for the note about states.ts, would it be sufficient to implement that change in the subsequent PRs?

#3334
#3335
#3336

@ScrewTSW ScrewTSW merged commit 439c9c1 into containers:main Sep 9, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Investigate and prepare PoC how to parse and extract AI Apps from ai.json file and execute tests with parameters
6 participants