Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ansible to podman-machine-os #68

Merged
merged 1 commit into from
Jan 22, 2025

Conversation

baude
Copy link
Member

@baude baude commented Jan 17, 2025

add ansible to the machine image so users can execute a playbook once the machine is booted. Users have been asking for a way to automaticaly configure a machine with various options, files (like certificates), and configuration tweaks. Ansible is an excellent tool to do this in the machine.

See also containers/podman#25043

Add ansible package to base image

@Luap99
Copy link
Member

Luap99 commented Jan 20, 2025

Can you add more information why this is needed/wanted?
I get that one needs ansible to run ansible playbook. But why do users need this? Is there an issue/discuss why we want this? I am confused because generally ansible is installed on a client and then manages 1 to N remote hosts that do not need to have ansible installed AFAIK.

For reference looking at the image size on main compared to this PR we get a noticeable size increase of like 65 MB:
https://cirrus-ci.com/task/5678762911596544
https://cirrus-ci.com/task/5462576722608128

That is no reason not to add things of course but everything we do add should have a strong justification hence my question.

add ansible to the machine image so users can execute a playbook once
the machine is booted.  Users have been asking for a way to automaticaly
configure a machine with various options, files (like certificates), and
configuration tweaks.  Ansible is an excellent tool to do this in the
machine.

See also containers/podman#25043

Signed-off-by: Brent Baude <[email protected]>
Copy link
Member

@Luap99 Luap99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@jakecorrenti jakecorrenti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as well. Tested the image on Linux and no issues

Copy link
Member

@Luap99 Luap99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link

openshift-ci bot commented Jan 22, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: baude, jakecorrenti, Luap99

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 9b8ef76 into containers:main Jan 22, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants