Add podman machine cp subcommand
#25331
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: jakecorrenti The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
jakecorrenti
force-pushed
the
machine-cp
branch
from
0e3d563 to
18304ce
Compare
jakecorrenti
force-pushed
the
machine-cp
branch
2 times, most recently
from
914a438 to
55cf202
Compare
jakecorrenti
force-pushed
the
machine-cp
branch
from
55cf202 to
076256f
Compare
pkg/machine/e2e/cp_test.go
Outdated
| if testProvider.VMType() == define.AppleHvVirt { | ||
| Expect(session.errorToString()).To(ContainSubstring(fmt.Sprintf("scp: open local \"%s\": No such file or directory", hostDirPath))) | ||
| } else { | ||
| Expect(session.errorToString()).To(ContainSubstring(fmt.Sprintf("scp: open local \"%s\": Is a directory", hostDirPath))) | ||
| } |
There was a problem hiding this comment.
I don't have a windows machine accessible at the moment, so I still need to figure out the error message checking here (I should also be checking if GOOS is macos not the provider here...)
jakecorrenti
force-pushed
the
machine-cp
branch
3 times, most recently
from
eaf21be to
0ed0ba3
Compare
|
one question i guess else LGTM |
jakecorrenti
force-pushed
the
machine-cp
branch
from
0ed0ba3 to
eed8e8f
Compare
jakecorrenti
force-pushed
the
machine-cp
branch
2 times, most recently
from
ea13c54 to
602102f
Compare
Add a new `podman machine cp` subcommand to allow users to copy files or directories between a running Podman Machine and their host. Tests cover the following cases: - Copy a file from the host machine to the VM - Copy a directory from the host machine to the VM - Copy a file from the VM to the host machine - Copy a directory from the VM to the host machine - Copy a file to a directory - Copy a directory to a file Signed-off-by: Jake Correnti <[email protected]>
jakecorrenti
force-pushed
the
machine-cp
branch
from
602102f to
b7b6dc7
Compare
| } | ||
|
|
||
| // Passing an absolute windows path of the format <volume>:\<path> will cause | ||
| // `copy.ParseSourceAndDestination` to think the volume is a Machine. Check |
There was a problem hiding this comment.
just thinking about it does podman cp not have the exact same issue, i.e. should this fix be moved into ParseSourceAndDestination()?
There was a problem hiding this comment.
Wouldn't that result in the same issue mentioned below having to do with single name containers?
| if specgen.IsHostWinPath(args[0]) { | ||
| srcMachine = "" | ||
| srcPath = args[0] | ||
| } | ||
|
|
||
| if specgen.IsHostWinPath(args[1]) { | ||
| destMachine = "" | ||
| destPath = args[1] | ||
| } |
There was a problem hiding this comment.
Also isn't this breaking for machine names with one letter? i.e. I think it runs into the same issue as shown in #25323
We do allow a machine called C so that can be a problem although super unlikely that anyone would be using single letter machine names hopefully so I am fine to ignore that part for now. Though adding this issue in a comment here might help future readers.
Does this PR introduce a user-facing change?
Adds a new
podman machine cpsubcommand. This will allow users to copy files or directories between a running Podman Machine and their host.