-
Notifications
You must be signed in to change notification settings - Fork 2.7k
Quadlet - fix dropin overwrites if different parent dirs #26557
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, I think a test case would be good so we don't regress in the future.
I don't see any existing tests that could extended for this @ygalblum do you have a idea what would be the best way to check this?I guess some new unit tests for loadUnitDropins()
is needed?
Maybe add it as part of the system test: podman/test/system/252-quadlet.bats Line 1793 in 8234879
|
fixes containers#26555 Signed-off-by: Andreas <[email protected]>
I pushed added a test here so we can move ahead with this and get this fix merged |
Test to ensure subdir overwrites work correctly, see containers#26555. Signed-off-by: Paul Holzinger <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: eulores, ygalblum The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@mheon PTAL |
/lgtm |
62dd921
into
containers:main
fixes #26555
Does this PR introduce a user-facing change?