-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add support for custom root CAs #185
Draft
piksel
wants to merge
8
commits into
main
Choose a base branch
from
feature/custom-tls-certs
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
custom CA support was added to the common webclient, which is now used by slack, telegram, pushbullet and gotify additionally, the SMTP service got a custom implementation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #185 +/- ##
===========================================
+ Coverage 64.06% 76.23% +12.16%
===========================================
Files 86 90 +4
Lines 2758 2748 -10
===========================================
+ Hits 1767 2095 +328
+ Misses 839 470 -369
- Partials 152 183 +31 ☔ View full report in Codecov by Sentry. |
piksel
commented
Jul 27, 2021
piksel
force-pushed
the
feature/custom-tls-certs
branch
2 times, most recently
from
August 11, 2021 08:14
0c39f09
to
c1312da
Compare
piksel
force-pushed
the
feature/custom-tls-certs
branch
from
August 16, 2021 08:57
c1312da
to
41c0918
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Custom CA support added to the common webclient (
pkg/common/webclient
), which is now used byslack
,telegram
,pushbullet
andgotify
.Additionally, the SMTP service got a custom implementation.
Adapting the rest of the services to use
webclient
should be really easy and can be made separately (although releasing with this only supported by some services would need a lot of documentation updates).Needs integration testing (and more unit tests) and a
Router
API.