Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace deprecated RSS reader with feed reader #60

Open
wants to merge 3 commits into
base: 5.3.x
Choose a base branch
from
Open

Replace deprecated RSS reader with feed reader #60

wants to merge 3 commits into from
+49 −20

Conversation

de-es
Copy link
Contributor

@de-es de-es commented Jan 19, 2025

Depends on contao/contao#7904

@zoglo zoglo self-requested a review January 19, 2025 13:27
@zoglo zoglo added this to the 5.3 milestone Jan 19, 2025
@zoglo zoglo added the migration Migrating deprecated modules / etc to a new feature label Jan 19, 2025
@de-es de-es marked this pull request as ready for review January 20, 2025 20:40
zoglo
zoglo requested changes Jan 20, 2025
View reviewed changes
Copy link
Member

@zoglo zoglo left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did not test it yet but there's a few things to match the code style of the project :) (mostly nitpicks)

files/contaodemo/theme/src/scss/components/_feed-reader.scss Outdated Show resolved Hide resolved
files/contaodemo/theme/src/scss/app.scss Show resolved Hide resolved
@zoglo
Copy link
Member

zoglo commented Jan 20, 2025

@de-es I've tested everything, and would be okay with it once the requested changes are in.
The biggest change here would be that it's called Feed Reader rather than RSS Reader but that's just a chore

The wrong order is a bug anyways: contao/contao#7905

@zoglo zoglo requested a review from sascha-mueller January 20, 2025 22:16
@de-es @zoglo
CS
a3d3cd3 
Co-authored-by: Sebastian Zoglowek <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zoglo zoglo zoglo requested changes

@sascha-mueller sascha-mueller Awaiting requested review from sascha-mueller

Assignees

@de-es de-es

Labels
migration Migrating deprecated modules / etc to a new feature
Projects
None yet
Milestone
5.3
Development

Successfully merging this pull request may close these issues.
2 participants
@de-es @zoglo