fix(types): revert "Export type declarations to support use as librar… #1116
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
damienxy
approved these changes
Sep 28, 2022
|
🎉 This PR is included in version 4.9.6 🎉 The release is available on: Your semantic-release bot 📦🚀 |
ghost
added
the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Aims to solve #1115.
Assumption is that with this PR we introduced exporting an empty
index.d.tsfile which (even is there is no types property inpackage.json) is picked up by other repositories instead of the hand-writtenindex.d.tsin the root folder which then causes typescript errors.We still want to go down the route of exposing index.d.ts files in our build folder, but this is just a hot fix for the broken release.