fix: remove old backgroundImage properties [SPA-2836] #1151
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Chaoste
changed the title
Chaoste
force-pushed
the
fix/SPA-remove-old-bg-img-support
branch
from
5b1257b to
5d4346e
Compare
dimitrycf
force-pushed
the
v2-prerelease
branch
2 times, most recently
from
8e5a6f1 to
4ca87d3
Compare
dimitrycf
approved these changes
Jun 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Before we officially released the product, we used a different way of defining options for background images.
Back then, we added a backward compatibility logic before moving to the final unified
cfBackgroundImageOptions.Support for this was removed ~1,5 years ago (e.g. #482). So, no customers could have built an actual experience with those that we still have to support today. We can safely remove it.