fix: space key handling for editable elements inside button #419
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage Report
File Coverage
|
||||||||||||||||||||||||||||||||||||||
There was a problem hiding this comment.
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (2)
src/visualBuilder/utils/handleFieldMouseDown.ts:55
- Consider verifying that 'event.composedPath' is supported before using it to avoid potential runtime errors in older or non-standard browsers.
if (event.composedPath().some(
src/visualBuilder/index.ts:65
- [nitpick] The name 'focusFieldReceivedInput' might be unclear; consider renaming it to 'hasReceivedInput' for improved readability.
focusFieldReceivedInput: boolean;
faraazb
force-pushed
the
VE-5803-space-key-element-inside-button
branch
2 times, most recently
from
e0055ea to
c2070f7
Compare
…ed path If there is a button element on the composed path, then the browser will send a click event on the button when space key is pressed. stopPropagation does not work as this is not a propagated event but something done by the browser. So, whenever a button is detected on the event's composed path, use custom space key handling.
faraazb
force-pushed
the
VE-5803-space-key-element-inside-button
branch
from
c2070f7 to
5dc41a2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If there is a button element on the composed path, then the browser will send a click event on the button when space key is pressed in a nested element with contenteditable set to true.
stopPropagationdoes not work as this is not a propagated event but a new event dispatched by the browser on the button element.Due to this, the button itself or closest element with CSLP may get focussed.
So, whenever a button is found on the event's composed path, use custom space key handling.