feat: Improve ProtocolClient initialization and GUI loading #4759
Conversation
- Introduce `onProtocolClientInitialized` to handle client initialization events. - Use `Delegates.observable` for `ideProtocolClient` to trigger listeners on changes. - Ensure URL loading is deferred until protocol client is initialized.
✅ Deploy Preview for continuedev canceled.
|
|
hi @lkk214 I would like to ask if you think this color rendering issue is related to your PR this time. If it is, I think I should merge your fix code this time |
|
@AfterStories I haven’t encountered this specific issue before, but I believe it might be related to this PR. Could you try using it to see if the color rendering issue can be reproduced? |
|
@lkk214 I like the changes here! I think this is important enough that we should probably attempt to write a quick e2e test to capture the behavior. I want to make sure that this doesn't cause a loop where the tool window is waiting infinitely, and it's an opportunity to make sure that the colors actually arrive. I think many different tests could suffice, but one example would be checking that the tool window correctly gets the colors. |
|
@sestinj I can add an e2e test for it, but I see that the code for the GUI test is commented. I don't understand why it is commented, maybe the GUI test cannot pass normally.I can add some e2e tests after reusing the GUI tests. This PR will not cause the tool window to wait indefinitely. It just ensures that the URL is not loaded before the ideProtocolClient is initialized, ensuring that |
Description
Some messages will be lost if the "Continue" tool window is open during JetBrains IDE startup, as this can cause the GUI to initialize without data.
Affected message types:
jetbrains/isOSREnabled,jetbrains/getColors,jetbrains/onLoad, etc.Currently, it is obvious that you can't right-click and "Open Dev Tools", and the theme color of the GUI is unexpected. These issues occur specifically when the "Continue" tool window is open during JetBrains IDE startup.