Skip to content

Jacob/enhancement/nextedit perf #6661

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jul 28, 2025
Merged

Conversation

jpoly1219
Copy link
Collaborator

@jpoly1219 jpoly1219 commented Jul 16, 2025

Description

Closes CON-2791, CON-2797.

Small snappiness improvements

  • Reduce redundant calculations
  • Windows disappear immediately
  • Remove redundant hide operations (could be why isNextEditActive context is being cleared prematurely)

Checklist

  • I've read the contributing guide
  • The relevant docs, if any, have been updated or created
  • The relevant tests, if any, have been updated or created

Screenshots

[ For visual changes, include screenshots. Screen recordings are particularly helpful, and appreciated! ]

Tests

[ What tests were added or updated to ensure the changes work as expected? ]


Summary by cubic

Improved NextEdit window performance by reducing redundant calculations and making windows disappear immediately for a snappier user experience. Also removed extra hide operations to prevent premature clearing of context.

  • Bug Fixes
    • Fixed potential issue where isNextEditActive context was cleared too early.

@jpoly1219 jpoly1219 requested a review from a team as a code owner July 16, 2025 16:42
@jpoly1219 jpoly1219 requested review from tomasz-stefaniak and removed request for a team July 16, 2025 16:42
@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Jul 16, 2025
@github-project-automation github-project-automation bot moved this from Todo to In Progress in Issues and PRs Jul 28, 2025
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jul 28, 2025
@tomasz-stefaniak tomasz-stefaniak merged commit c9e15dd into main Jul 28, 2025
124 of 128 checks passed
@tomasz-stefaniak tomasz-stefaniak deleted the jacob/enhancement/nextedit-perf branch July 28, 2025 17:54
@github-project-automation github-project-automation bot moved this from In Progress to Done in Issues and PRs Jul 28, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Jul 28, 2025
@sestinj
Copy link
Contributor

sestinj commented Jul 28, 2025

🎉 This PR is included in version 1.4.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@sestinj
Copy link
Contributor

sestinj commented Jul 28, 2025

🎉 This PR is included in version 1.6.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm This PR has been approved by a maintainer released size:L This PR changes 100-499 lines, ignoring generated files.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants