Skip to content

fix: improve image URL parsing robustness across providers #8015

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 7 commits into from
Closed

fix: improve image URL parsing robustness across providers #8015

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
f18b0a7
fix: improve image URL parsing robustness across providers
dcs-soni Sep 29, 2025
3436b3e
refactor: extract url parsing logic to utilities
dcs-soni Oct 2, 2025
2baf4d5
Merge remote-tracking branch 'upstream/main' into fix/robust-image-ur…
dcs-soni Oct 7, 2025
fb90ae7
fix prettier ci checks
dcs-soni Oct 7, 2025
da05fbe
Merge branch 'main' into fix/robust-image-url-parsing
dcs-soni Oct 14, 2025
0fa9dd9
Merge branch 'main' into fix/robust-image-url-parsing
dcs-soni Oct 14, 2025
eac212e
Merge branch 'main' into fix/robust-image-url-parsing
dcs-soni Oct 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions .continue/prompts/core-unit-test.prompt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@ IMPORTANT: Do NOT mock the fixtures above other than using `jest.spyOn`. DO mock
Instead, generate actual mock files and data for operations
Pure mocks should only be used to emulate specific network responses/error or hard-to-duplicate errors, or to prevent long-duration tests

Additional types can be imported from @core/index.d.ts. If any needed types, functions, constants, or classes are still not found, warn the user and do not generate tests.
Additional types can be imported from @core/index.d.ts
If any needed types, functions, constants, or classes are still not found, warn the user and do not generate tests.

Write the comment "// Generated by continue" at the top of the generated code/file (not the filepath)
Write the comment "// Generated by continue" at the top of the generated code/file (not the filepath)
8 changes: 1 addition & 7 deletions .github/actions/setup-component/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,18 +31,12 @@ runs:
packages/*/node_modules
key: ${{ runner.os }}-packages-node-modules-${{ hashFiles('packages/*/package-lock.json') }}

- uses: actions/cache@v4
- uses: actions/cache@v4
Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot Oct 22, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With this change the include-root path now only restores the cache, but never runs npm ci on a cache miss. On a fresh runner node_modules stays empty, so any workflow that sets include-root=true and expects root packages will fail.

Prompt for AI agents 
Address the following comment on .github/actions/setup-component/action.yml at line 34:

<comment>With this change the include-root path now only restores the cache, but never runs npm ci on a cache miss. On a fresh runner node_modules stays empty, so any workflow that sets include-root=true and expects root packages will fail.</comment>

<file context>
@@ -31,18 +31,12 @@ runs:
         key: ${{ runner.os }}-packages-node-modules-${{ hashFiles(&#39;packages/*/package-lock.json&#39;) }}
 
-    - uses: actions/cache@v4
+    - uses: actions/cache@v4  
       if: inputs.include-root == &#39;true&#39;
-      id: root-cache
</file context>
Fix with Cubic

if: inputs.include-root == 'true'
id: root-cache
with:
path: node_modules
key: ${{ runner.os }}-root-node-modules-${{ hashFiles('package-lock.json') }}

- name: Install root dependencies
if: inputs.include-root == 'true' && steps.root-cache.outputs.cache-hit != 'true'
shell: bash
run: npm ci

- uses: actions/cache@v4
id: component-cache
with:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/auto-fix-failed-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@ jobs:

- name: Setup Node.js
if: steps.workflow-details.outputs.has_failed_tests == 'true'
uses: actions/setup-node@v6
uses: actions/setup-node@v5
with:
node-version: "20"

Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/beta-release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ jobs:
token: ${{ secrets.SEMANTIC_RELEASE_TOKEN }}

- name: Setup Node.js
uses: actions/setup-node@v6
uses: actions/setup-node@v5
with:
node-version: 20
registry-url: "https://registry.npmjs.org"
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/cli-pr-checks.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ jobs:
uses: actions/checkout@v5

- name: Setup Node.js
uses: actions/setup-node@v6
uses: actions/setup-node@v5
with:
node-version: 20
cache: "npm"
Expand Down Expand Up @@ -67,7 +67,7 @@ jobs:
uses: actions/checkout@v5

- name: Setup Node.js ${{ matrix.node-version }}
uses: actions/setup-node@v6
uses: actions/setup-node@v5
with:
node-version: ${{ matrix.node-version }}

Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/compliance.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,7 @@ jobs:
uses: actions/checkout@v5

- name: Setup Node.js
uses: actions/setup-node@v6
uses: actions/setup-node@v5
with:
node-version-file: ".nvmrc"
cache: "npm"
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/continue-general-review.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ name: Continue General Review
on:
push:
branches:
- main
- nate/fix-wf
Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot Oct 22, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Limiting the push trigger to the personal nate/fix-wf branch stops the general review workflow from running on main, removing coverage for the default branch.

Prompt for AI agents 
Address the following comment on .github/workflows/continue-general-review.yaml at line 6:

<comment>Limiting the push trigger to the personal `nate/fix-wf` branch stops the general review workflow from running on `main`, removing coverage for the default branch.</comment>

<file context>
@@ -3,7 +3,7 @@ name: Continue General Review
   push:
     branches:
-      - main
+      - nate/fix-wf
   pull_request:
     types: [opened, ready_for_review]
</file context>
Suggested change
- nate/fix-wf
- main
Fix with Cubic

pull_request:
types: [opened, ready_for_review]
issue_comment:
Expand All @@ -25,4 +25,4 @@ jobs:
with:
continue-api-key: ${{ secrets.CONTINUE_API_KEY }}
continue-org: "continuedev"
continue-agent: "empty-agent"
continue-config: "continuedev/review-bot"
24 changes: 0 additions & 24 deletions .github/workflows/delete-stale-branches.yaml
View file
Open in desktop

This file was deleted.

4 changes: 2 additions & 2 deletions .github/workflows/jetbrains-release.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,7 +152,7 @@ jobs:

# # Setup Node.js
- name: Use Node.js from .nvmrc
uses: actions/setup-node@v6
uses: actions/setup-node@v5
with:
node-version-file: ".nvmrc"

Expand Down Expand Up @@ -370,7 +370,7 @@ jobs:

# 2. Install npm dependencies
- name: Use Node.js from .nvmrc
uses: actions/setup-node@v6
uses: actions/setup-node@v5
with:
node-version-file: ".nvmrc"

Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/main.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ jobs:
with:
fetch-depth: 0

- uses: actions/setup-node@v6
- uses: actions/setup-node@v5
with:
node-version-file: ".nvmrc"

Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/pr-checks.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ jobs:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v5
- uses: actions/setup-node@v6
- uses: actions/setup-node@v5
with:
node-version-file: ".nvmrc"

Expand Down Expand Up @@ -229,7 +229,7 @@ jobs:
test_file_matrix: ${{ steps.vscode-get-test-file-matrix.outputs.test_file_matrix }}
steps:
- uses: actions/checkout@v5
- uses: actions/setup-node@v6
- uses: actions/setup-node@v5
with:
node-version-file: ".nvmrc"

Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/preview.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ jobs:
with:
fetch-depth: 0

- uses: actions/setup-node@v6
- uses: actions/setup-node@v5
with:
node-version-file: ".nvmrc"

Expand Down Expand Up @@ -165,7 +165,7 @@ jobs:

# 4. Create PR with version bump
- name: Setup Node.js
uses: actions/setup-node@v6
uses: actions/setup-node@v5
with:
node-version-file: ".nvmrc"

Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/reusable-release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ jobs:
uses: ./.github/actions/setup-packages

- name: Use Node.js from .nvmrc
uses: actions/setup-node@v6
uses: actions/setup-node@v5
with:
node-version-file: ".nvmrc"

Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/run-continue-agent.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,8 @@ on:
description: "The prompt to send to the Continue agent"
required: true
type: string
config:
description: "The config to use (e.g., continuedev/default-background-agent)"
agent:
description: "The agent to use (e.g., continuedev/default-background-agent)"
required: false
type: string
default: "continuedev/default-background-agent"
Expand All @@ -33,7 +33,7 @@ jobs:
-H "Authorization: Bearer ${{ secrets.CONTINUE_API_KEY }}" \
-d '{
"prompt": "${{ inputs.prompt }}",
"config": "${{ inputs.config }}",
"agent": "${{ inputs.agent }}",
"branchName": "${{ inputs.branch_name }}",
"repoUrl": "https://github.com/${{ github.repository }}"
}')
Expand Down
4 changes: 3 additions & 1 deletion .github/workflows/runloop-blueprint-template.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,8 @@
"system_setup_commands": [
"npm i -g @continuedev/cli@latest",
"sudo apt update",
"sudo apt install -y ripgrep"
"sudo apt install -y ripgrep",
"sudo apt install asciinema",
Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot Oct 22, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add the -y flag so this apt install runs non-interactively on the GitHub Actions runner; otherwise the job will hang waiting for confirmation.

Prompt for AI agents 
Address the following comment on .github/workflows/runloop-blueprint-template.json at line 7:

<comment>Add the `-y` flag so this apt install runs non-interactively on the GitHub Actions runner; otherwise the job will hang waiting for confirmation.</comment>

<file context>
@@ -3,6 +3,8 @@
     &quot;sudo apt update&quot;,
-    &quot;sudo apt install -y ripgrep&quot;
+    &quot;sudo apt install -y ripgrep&quot;,
+    &quot;sudo apt install asciinema&quot;,
+    &quot;sudo apt install expect&quot;
   ]
</file context>
Suggested change
"sudo apt install asciinema",
"sudo apt install -y asciinema",
Fix with Cubic

"sudo apt install expect"
Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot Oct 22, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Include the -y flag so this apt install remains non-interactive; without it the workflow will block waiting for user input.

Prompt for AI agents 
Address the following comment on .github/workflows/runloop-blueprint-template.json at line 8:

<comment>Include the `-y` flag so this apt install remains non-interactive; without it the workflow will block waiting for user input.</comment>

<file context>
@@ -3,6 +3,8 @@
-    &quot;sudo apt install -y ripgrep&quot;
+    &quot;sudo apt install -y ripgrep&quot;,
+    &quot;sudo apt install asciinema&quot;,
+    &quot;sudo apt install expect&quot;
   ]
 }
</file context>
Suggested change
"sudo apt install expect"
"sudo apt install -y expect"
Fix with Cubic

]
}
31 changes: 0 additions & 31 deletions .github/workflows/snyk-agent.yaml
View file
Open in desktop

This file was deleted.

2 changes: 1 addition & 1 deletion .github/workflows/stable-release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ jobs:
token: ${{ secrets.SEMANTIC_RELEASE_TOKEN }}

- name: Setup Node.js
uses: actions/setup-node@v6
uses: actions/setup-node@v5
with:
node-version: 20
registry-url: "https://registry.npmjs.org"
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/tidy-up-codebase.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ jobs:
uses: ./.github/workflows/run-continue-agent.yml
with:
prompt: "Review every Markdown documentation file and verify that descriptions, examples, or behavior outlines accurately reflect the current code. Only update documentation; do not modify code. Check the corresponding code to confirm behavior before making changes. Correct any inaccuracies or outdated information in descriptions, examples, or behavior outlines. Preserve existing Markdown formatting, style, and structure. Do not add new sections, speculative explanations, or details not present in the code. Only update statements that are clearly incorrect or misleading; do not rewrite text for style or preference. Keep edits minimal and focused, ensuring that the Markdown matches what the code actually does. If verification against the code is ambiguous, leave the documentation unchanged. Use branch name bot/cleanup-<YYMMDD>-<HHMM>"
config: continuedev/default-background-agent
agent: continuedev/default-background-agent
branch_name: main
secrets:
CONTINUE_API_KEY: ${{ secrets.CONTINUE_API_KEY }}
2 changes: 1 addition & 1 deletion .github/workflows/vscode-prerelease.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ jobs:
token: ${{ secrets.GITHUB_TOKEN }}

- name: Setup Node.js
uses: actions/setup-node@v6
uses: actions/setup-node@v5
with:
node-version: 20

Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/vscode-version-bump.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ jobs:
gh auth login --with-token <<< "${{ github.token }}"

- name: Use Node.js from .nvmrc
uses: actions/setup-node@v6
uses: actions/setup-node@v5
with:
node-version-file: ".nvmrc"

Expand Down
Loading
Loading