Commenting out code for creating 2nd interface on VMs. Not needed. Ch… - #361
Commenting out code for creating 2nd interface on VMs. Not needed. Ch…#361dojacobs wants to merge 1 commit into
Conversation
…anging machine to t2.micro to save money.
neelimamukiri
left a comment
neelimamukiri
left a comment
There was a problem hiding this comment.
LGTM. Can we may be split this into two - aws.tf and aws-large.tf or something similar, instead of having commented out and stale code?
|
Since this is only used by Jenkins, I don't see a point in having a "small" and "large" version. If you would like, I could make machine type an external variable that you specify in the aws.tfvars file or it could be specified on the command line when you do the terraform apply. Otherwise it's just one line inside the script to change the machine type that is used. |
|
@dojacobs, in that case why not just delete the commented lines? |
|
@rhim's thinking was that we might need them in the future. It's no big deal either way. What is the normal process? |
|
Updated file with the commented lines deleted. |
|
@contiv/maintainers-deployment PTAL |
3 participants
…anging machine to t2.micro to save money.