Skip to content

Bump PHPStan to 2.0 #115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 17, 2025
Merged

Bump PHPStan to 2.0 #115

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7dc3379
PHPStan: Fix getForm() result type
jtojnar Jan 11, 2025
07a1009
Bump PHPStan to 2.0
jtojnar Jan 11, 2025
9533530
phpstan: Ignore Container::getComponents() returning incorrect type
jtojnar Jan 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
"nette/di": "^3.1.0",
"latte/latte": "^3.0.0",
"contributte/qa": "^0.3",
"contributte/phpstan": "^0.1",
"contributte/phpstan": "^0.2",
"webchemistry/testing-helpers": "^4.0.0"
},
"conflict": {
Expand Down
8 changes: 8 additions & 0 deletions phpstan.neon
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,3 +16,11 @@ parameters:
paths:
- src
- .docs

ignoreErrors:
# https://github.com/phpstan/phpstan-nette/issues/141
-
message: '#^Parameter \#1 \$array of function array_filter expects array, Iterator\<int\|string, Nette\\ComponentModel\\IComponent\> given\.$#'
identifier: argument.type
count: 3
path: src/Multiplier.php
5 changes: 4 additions & 1 deletion src/Multiplier.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,6 +110,9 @@ public static function register(string $name = 'addMultiplier'): void
});
}

/**
* @return ($throw is true ? Form : ?Form)
*/
public function getForm(bool $throw = true): ?Form
{
if ($this->form) {
Expand Down Expand Up @@ -378,7 +381,7 @@ protected function isValidMaxCopies(): bool

protected function isFormSubmitted(): bool
{
return $this->getForm() !== null && $this->getForm()->isAnchored() && $this->getForm()->isSubmitted();
return $this->getForm(false) !== null && $this->getForm()->isAnchored() && $this->getForm()->isSubmitted();
}

protected function loadHttpData(): void
Expand Down
Loading