-
Notifications
You must be signed in to change notification settings - Fork 0
884: Ruby Upgrade #9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 6 commits
57ff998
1abd29d
8e85590
3fa6316
60a40dc
56d5ec1
bb8eaee
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1 @@ | ||
| 3.1.4 | ||
| 4.0.1 |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,11 @@ | ||
| # Changelog | ||
|
|
||
| ## [1.1.0] - 2026-02-11 | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🤔 Arguably we could do a major version bump since there are breaking changes in here, but i don't feel strongly about it
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Not a bad idea
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Major version bump sounds good in any other scenario. However, I do like being able to eye-ball a semver across all our ruby repos and see if includes the ruby + faraday upgrade or not. Currently, all gems we maintain with Ruby 4.0 and/or Faraday 2.14 have a semver 1.x For that selfish reason, I'll keep the semver as is. |
||
|
|
||
| ### BREAKING CHANGES | ||
| - Now requires Faraday 2.x (previously supported Faraday 1.x) | ||
| - Dropped support for Ruby versions older than 3.3. Officially supported versions are Ruby 3.3, 3.4, and 4.0. | ||
|
|
||
| ## [1.0.0] - 2023-10-17 | ||
|
|
||
| ### BREAKING CHANGES | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,38 +1,8 @@ | ||
| # frozen_string_literal: true | ||
|
|
||
| require 'rubygems' | ||
| require 'bundler' | ||
| begin | ||
| Bundler.setup(:default, :development) | ||
| rescue Bundler::BundlerError => e | ||
| warn e.message | ||
| warn 'Run `bundle install` to install missing gems' | ||
| exit e.status_code | ||
| end | ||
| require 'rake' | ||
|
|
||
| require 'bundler/gem_tasks' | ||
| require 'rspec/core/rake_task' | ||
| desc 'Run specs' | ||
| RSpec::Core::RakeTask.new do |t| | ||
| t.pattern = './spec/**/*_spec.rb' # don't need this, it's default. | ||
| t.rspec_opts = '--color' | ||
| end | ||
|
|
||
| desc 'Code coverage detail' | ||
| task :simplecov do | ||
| ENV['COVERAGE'] = 'true' | ||
| Rake::Task['test'].execute | ||
| end | ||
| RSpec::Core::RakeTask.new(:spec) | ||
|
|
||
| desc 'Default: run specs' | ||
| task default: :spec | ||
|
|
||
| require 'rdoc/task' | ||
| Rake::RDocTask.new do |rdoc| | ||
| version = File.exist?('VERSION') ? File.read('VERSION') : '' | ||
|
|
||
| rdoc.rdoc_dir = 'rdoc' | ||
| rdoc.title = "engaging-networks-rest #{version}" | ||
| rdoc.rdoc_files.include('README*') | ||
| rdoc.rdoc_files.include('lib/**/*.rb') | ||
| end |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1 @@ | ||
| 1.0.0 | ||
| 1.1.0 |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,42 +1,38 @@ | ||
| # frozen_string_literal: true | ||
|
|
||
| Gem::Specification.new do |s| | ||
| s.name = "engaging-networks-rest".freeze | ||
| s.version = "1.0.0" | ||
|
|
||
| s.required_rubygems_version = Gem::Requirement.new(">= 0".freeze) if s.respond_to? :required_rubygems_version= | ||
| s.require_paths = ["lib".freeze] | ||
| s.authors = ["Grey Moore".freeze] | ||
| s.date = "2023-10-17" | ||
| s.description = "Client gem for the ENS API to Engaging Networks".freeze | ||
| s.email = "systems@controlshiftlabs.com".freeze | ||
| s.extra_rdoc_files = [ | ||
| "LICENSE", | ||
| "LICENSE.txt", | ||
| "README.md" | ||
| ] | ||
|
|
||
| # Specify which files should be added to the gem when it is released. | ||
| # The `git ls-files -z` loads the files in the RubyGem that have been added into git. | ||
| s.files = Dir.chdir(File.expand_path(__dir__)) do | ||
| lib = File.expand_path('lib', __dir__) | ||
| $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib) | ||
|
|
||
| Gem::Specification.new do |spec| | ||
| spec.name = 'engaging-networks-rest' | ||
| spec.version = File.read(File.expand_path('VERSION', __dir__)).strip | ||
| spec.authors = ['Grey Moore', 'Owens Ehimen', 'Diego Marcet'] | ||
| spec.email = ['talk@controlshiftlabs.com'] | ||
|
|
||
| spec.summary = 'Client gem for the ENS API to Engaging Networks' | ||
| spec.description = 'Client gem for the ENS API to Engaging Networks' | ||
| spec.homepage = 'https://github.com/controlshift/engaging-networks-rest' | ||
| spec.license = 'MIT' | ||
|
|
||
| spec.files = Dir.chdir(File.expand_path(__dir__)) do | ||
| `git ls-files -z`.split("\x0").reject { |f| f.match(%r{^(test|spec|features)/}) } | ||
| end | ||
| spec.require_paths = ['lib'] | ||
|
|
||
| s.homepage = 'https://github.com/controlshift/engaging-networks-rest'.freeze | ||
| s.licenses = ["MIT".freeze] | ||
| s.summary = "Client gem for the ENS API to Engaging Networks".freeze | ||
| spec.required_ruby_version = ['>= 3.3', '< 5.0'] | ||
|
|
||
| if s.respond_to? :specification_version then | ||
| s.specification_version = 4 | ||
| end | ||
| # Runtime dependencies | ||
| spec.add_runtime_dependency 'faraday', '~> 2.0' | ||
|
|
||
| s.add_runtime_dependency(%q<faraday>.freeze, [">= 1.0"]) | ||
| s.add_runtime_dependency(%q<faraday_middleware>.freeze, [">= 0"]) | ||
| # Development dependencies | ||
| spec.add_development_dependency 'bundler', '>= 2.0', '< 5.0' | ||
| spec.add_development_dependency 'debug', '~> 1.0' | ||
| spec.add_development_dependency 'faker', '~> 3.0' | ||
| spec.add_development_dependency 'faraday-detailed_logger', '~> 2.0' | ||
| spec.add_development_dependency 'rake', '~> 13.0' | ||
| spec.add_development_dependency 'rspec', '~> 3.0' | ||
| spec.add_development_dependency 'rubocop', '~> 1.0' | ||
| spec.add_development_dependency 'webmock', '~> 3.0' | ||
|
|
||
| s.add_development_dependency(%q<faker>.freeze, ["> 2.20.0"]) | ||
| s.add_development_dependency(%q<faraday-detailed_logger>.freeze, [">= 2.1.2"]) | ||
| s.add_development_dependency(%q<debug>.freeze, ["> 0"]) | ||
| s.add_development_dependency(%q<rspec>.freeze, [">= 0"]) | ||
| s.add_development_dependency(%q<rubocop>.freeze, [">= 0"]) | ||
| s.add_development_dependency(%q<webmock>.freeze, ["> 3.4"]) | ||
| spec.metadata['rubygems_mfa_required'] = 'true' | ||
| end |
Uh oh!
There was an error while loading. Please reload this page.