Encapsulate RestfulPattern Collections Using RestfulPatterns #26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Encapsulate a collection of RestfulPattern and provide utility methods. - Add static factory methods to create empty or from a collection. - Implement `noneMatches` method to check if no patterns match the request. - Provide `addAll` method to merge patterns from another RestfulPatterns. - Implement `getPaths` method to retrieve a list of pattern paths. - Set @SInCE to "Upcoming" for future release.
- Implement tests for RestfulPatterns class to validate functionality. - Test empty creation with RestfulPatterns.empty(). - Verify noneMatches method with different HTTP requests. - Test addAll method to merge patterns from another RestfulPatterns. - Check getPaths method to retrieve pattern paths.
- Replace direct List<RestfulPattern> usage with RestfulPatterns class - Simplify request matching logic by using noneMatches method from RestfulPatterns. - Update shouldSkip method to use RestfulPatterns for pattern matching. - Add addRestfulPatterns method to allow merging RestfulPatterns. - Improve maintainability and readability by using RestfulPatterns as a first-class collection.
- Modify test logic to reflect changes in RestInterceptor using RestfulPatterns.
- Replace collection-based addRestfulPatterns() method with a version that uses RestfulPatterns. - Streamline method to delegate to the `RestfulPatterns.from()` factory method for better readability and consistency. - Ensure path patterns are updated accordingly through RestfulPatterns getPaths() method.
cookie-meringue
changed the title
Test Results21 tests 21 ✅ 0s ⏱️ Results for commit ac9acbd. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #25