feat: Deprecate CreateChildSpan#410
Draft
nhhagen wants to merge 1 commit into
Draft
Conversation
policy-bot-coop-norge
Bot
requested review from
CRCOOP,
Dariusz-Wolontariusz,
Gjeitnes,
Henrik-glt,
JEHCoop,
andreasaaro,
geethu-mohan and
msporshe
hadrienk
previously approved these changes
Sep 26, 2024
AtzeDeVries
previously approved these changes
Sep 26, 2024
`github.com/coopnorge/go-datadog-lib/tracing.CreateChildSpan` nearly identical to `gopkg.in/DataDog/dd-trace-go.v1/ddtrace/tracer.StartSpanFromContext` there is little value for us to maintain our own version. `CreateChildSpan` does not return a context.Context making it impossible to create child spans and attach logs to correct span. Closes: #409
nhhagen
force-pushed
the
deprecate-create-child-span-2024-09-25-21-12-07
branch
from
6bce313 to
d8a4cf9
Compare
policy-bot-coop-norge
Bot
dismissed stale reviews from hadrienk and AtzeDeVries
Invalidated by push of d8a4cf9
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
github.com/coopnorge/go-datadog-lib/tracing.CreateChildSpannearly identicalto
gopkg.in/DataDog/dd-trace-go.v1/ddtrace/tracer.StartSpanFromContextthereis little value for us to maintain our own version.
CreateChildSpandoes not return a context.Context making it impossible tocreate child spans and attach logs to correct span.
Closes: #409