Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for Cloudwatch Metrics Stream via PriveLink #205

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

guyrenny
Copy link
Contributor

@guyrenny guyrenny commented Feb 5, 2025

Description

Ran terraform fmt for coralogix-aws-shipper directory
Add support in the module to send firehose cloudwatch metrics via private link
Fix a bug in null_resource where in case that you will ran multiple modules it will get an error when tried to delete source code file

Fixes #

How Has This Been Tested?

Checklist:

  • I have updated the relevant example in the examples directory for the module.
  • I have updated the relevant test file for the module.
  • This change does not affect module (e.g. it's readme file change)

@guyrenny guyrenny requested a review from a team as a code owner February 5, 2025 16:02
Copy link
Contributor

@juan-coralogix juan-coralogix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants