Skip to content

Conversation

@EladDv
Copy link
Contributor

@EladDv EladDv commented Oct 18, 2025

Added an accent color settings module for both apps screen and the settings app

tested on silk (just doesn't show up and uses the defaults), snowy and spalding in QEMU

for it to be expanded in the future for other apps will probably need a rewrite (unclear how dark/light/default modes will integrate into this too, might be able to squeeze it in this structure)

@EladDv
Copy link
Contributor Author

EladDv commented Oct 18, 2025

Themes settings menu in settings:
remmina_Quick Connect_127 0 0 1:5900_20251018-204407

Themes settings menu:
remmina_Quick Connect_127 0 0 1:5900_20251018-204413

Default option:
remmina_Quick Connect_127 0 0 1:5900_20251018-204418

Show all colors:
remmina_Quick Connect_127 0 0 1:5900_20251018-204423

Showing potential accent:
remmina_Quick Connect_127 0 0 1:5900_20251018-204439

Same with settings menu accent color:
remmina_Quick Connect_127 0 0 1:5900_20251018-204506

Results:
remmina_Quick Connect_127 0 0 1:5900_20251018-204446
remmina_Quick Connect_127 0 0 1:5900_20251018-204514

Copy link
Member

@jplexer jplexer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you shouldnt be able to set colors that text isnt readable on imho.

@EladDv
Copy link
Contributor Author

EladDv commented Oct 18, 2025

you shouldnt be able to set colors that text isnt readable on imho.

Which colors are you thinking about?
Changing it is super easy - just take them out of the list of colors in the settings_themes.h file (unless you want to separate the 2 lists but then it's just duplicating them and changing a few variables)

personally I think user freedom is always a plus (especially on a more "enthusiast" platform like this)

@jplexer
Copy link
Member

jplexer commented Oct 18, 2025

i.e. looks like black text is not readable on imperial purple
you dont have to remove colors, just make the text readable on them (i.e. on darker colors change text color to white and vice versa)!

@EladDv
Copy link
Contributor Author

EladDv commented Oct 18, 2025

i.e. looks like black text is not readable on imperial purple you dont have to remove colors, just make the text readable on them (i.e. on darker colors change text color to white and vice versa)!

sure that can be done but then you're in a whole dark/light mode situation and that's for a future PR , would a better preview display be better? would let the user see it before (so the text in the menu will be black in that case, and the bg in the settings portion will be black)

@jplexer
Copy link
Member

jplexer commented Oct 18, 2025

yeah I guess that would make sense!

@EladDv
Copy link
Contributor Author

EladDv commented Oct 18, 2025

The first one looks kinda jank... IDK if I 100% like it but at least for a start (I dont want to mess so much with the layers)
remmina_Quick Connect_127 0 0 1:5900_20251018-212821
remmina_Quick Connect_127 0 0 1:5900_20251018-212813

@jplexer
Copy link
Member

jplexer commented Oct 18, 2025

well you dont have to change the entire background, just the text color 😁

@EladDv
Copy link
Contributor Author

EladDv commented Oct 18, 2025

yeah but for the settings screen it's much more informative since it is black so you want to know if there's contrast there too
also removed black from the quick options and moved it to the end of the "all options" replace it with pink

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants