-
Couldn't load subscription status.
- Fork 35
fw/apps/system_apps/settings: add accent colors #379
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Elad Dvash <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you shouldnt be able to set colors that text isnt readable on imho.
Which colors are you thinking about? personally I think user freedom is always a plus (especially on a more "enthusiast" platform like this) |
|
i.e. looks like black text is not readable on imperial purple |
sure that can be done but then you're in a whole dark/light mode situation and that's for a future PR , would a better preview display be better? would let the user see it before (so the text in the menu will be black in that case, and the bg in the settings portion will be black) |
|
yeah I guess that would make sense! |
|
well you dont have to change the entire background, just the text color 😁 |
|
yeah but for the settings screen it's much more informative since it is black so you want to know if there's contrast there too |
Signed-off-by: Elad Dvash <[email protected]>










Added an accent color settings module for both apps screen and the settings app
tested on silk (just doesn't show up and uses the defaults), snowy and spalding in QEMU
for it to be expanded in the future for other apps will probably need a rewrite (unclear how dark/light/default modes will integrate into this too, might be able to squeeze it in this structure)