-
Notifications
You must be signed in to change notification settings - Fork 7
AppMessage classic PebbleKit Android implementation #16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
matejdro
wants to merge
10
commits into
coredevices:master
Choose a base branch
from
matejdro:pebblekit
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
6e6573a
generalize PKJSLifecycleManager into CompanionAppLifecycleManager
matejdro 3074eed
add AppMessage PebbleKit classic support
matejdro 9f34dbe
Fix inboundAppMessages not emitting early messages
matejdro c745f9e
Emit AppMessage unsigned numbers as ULong
matejdro d2f3a0a
Add PebbleKit start/stop listeners
matejdro 3d47cf0
Add PebbleKit Classic provider
matejdro c8e22e1
Use ordered intents for reduced latency
matejdro 664d7f8
Fix PebbleKitProvider throwing errors on startup
matejdro f13a73c
Cache AppMessages per-app
matejdro 8d5160d
Merge branch 'master' into pebblekit
matejdro File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
13 changes: 13 additions & 0 deletions
13
...rebble/libpebblecommon/connection/endpointmanager/CompanionAppLifecycleManager.android.kt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,13 @@ | ||
package io.rebble.libpebblecommon.connection.endpointmanager | ||
|
||
import io.rebble.libpebblecommon.connection.CompanionApp | ||
import io.rebble.libpebblecommon.js.CompanionAppDevice | ||
import io.rebble.libpebblecommon.metadata.pbw.appinfo.PbwAppInfo | ||
import io.rebble.libpebblecommon.pebblekit.PebbleKitClassic | ||
|
||
actual fun createPlatformSpecificCompanionAppControl( | ||
device: CompanionAppDevice, | ||
appInfo: PbwAppInfo | ||
): CompanionApp? { | ||
return PebbleKitClassic(device, appInfo) | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably worth noting that (unless we change libpebble so that it doesn't enable the gatt server by default) installing any other app using libpebble will break other apps (see
otherPebbleCompanionAppsInstalled
), so this might not really be a big problem. Leaving it like this is fine thoughThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hm, is the gatt server running even if no watches are set to connect?