Always generate + override [lib] for filtered crates
#114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Right of course our CI somehow bitrotted in the last few months even though nothing changed here, but I put up a fix in #115 |
The core way this project works for filtered crates is to replace them with a "stub" that only has an empty `src/lib.rs`. When processing the manifest previously, we didn't override the `lib` section that might have been present. Usually this worked because of autodiscovery. But in the corner case that arose recently in cxx where there was a `bin`-only crate as a build dependency, things broke because we dropped the `bin` section but didn't add a `lib`. Now arguably, there's a bug in `cargo` here because it dropped the dependency in `cargo metadata` but still checks it in `cargo build`. But anyways it's clearly correct here for us to have a canonical `lib` section always (whether it was present or not in the filtered crate) so do that. Closes: coreos#111
cgwalters
force-pushed
the
own-the-lib
branch
from
dad2bab to
20f2584
Compare
jeckersb
approved these changes
Jan 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The core way this project works for filtered crates is to replace them with a "stub" that only has an empty
src/lib.rs. When processing the manifest previously, we didn't override thelibsection that might have been present. Usually this worked because of autodiscovery.But in the corner case that arose recently in cxx where there was a
bin-only crate as a build dependency, things broke because we dropped thebinsection but didn't add alib.Now arguably, there's a bug in
cargohere because it dropped the dependency incargo metadatabut still checks it incargo build.But anyways it's clearly correct here for us to have a canonical
libsection always (whether it was present or not in the filtered crate) so do that.Closes: #111