Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rpmdistro-gitoverlay as a submodule rather than RPM #134

Closed
wants to merge 1 commit into from

Conversation

cgwalters
Copy link
Member

We want the ability to make breaking changes to how we build
RPMs; having it as a submodule will allow us to break things.

Further, today COPR doesn't support e.g. aarch64, which imposes
an artificial limitation on building this container.
(Today we're using the Ignition from COPR, but actually for
validating configs we could probably just use the main repo)

Obsoletes: #30

We want the ability to make breaking changes to how we build
RPMs; having it as a submodule will allow us to break things.

Further, today COPR doesn't support e.g. aarch64, which imposes
an artificial limitation on building this container.
(Today we're using the Ignition from COPR, but actually for
 validating configs we could probably just use the main repo)

Obsoletes: coreos#30
@dustymabe
Copy link
Member

We want the ability to make breaking changes to how we build
RPMs; having it as a submodule will allow us to break things.

Can you elaborate on the 'breaking things' part? I was hoping to move more the way of #52 here. i.e. build less external tools and pull them from pre-built places.

Further, today COPR doesn't support e.g. aarch64, which imposes
an artificial limitation on building this container.

yeah. we should resolve and not pull from copr in the long run, right?

@cgwalters
Copy link
Member Author

Can you elaborate on the 'breaking things' part?

We may want the ability to change rpmdistro-gitoverlay. I'm not very happy with the implementation.

I was hoping to move more the way of #52 here. i.e. build less external tools and pull them from pre-built places.

Yeah, we can also hold this on resolving #52.

Of course though this issue gets a bit meta in that rdgo and copr overlap significantly.

@dustymabe dustymabe added the hold waiting on something label Oct 1, 2018
@stellirin
Copy link

stellirin commented Nov 8, 2018

In this case the result is a noarch rpm so an alternative work around is to simply point directly to the file location

dnf install -y https://copr-be.cloud.fedoraproject.org/results/walters/buildtools-fedora/fedora-29-x86_64/00820725-rpmdistro-gitoverlay/rpmdistro-gitoverlay-2018.1.16.g2688b38-1.fc29.noarch.rpm

However an architecture agnostic solution would be appreciated (the above doesn't help for the other cases where binary rpms are overridden with x86_64 only repos)

@cgwalters
Copy link
Member Author

Obsoleted by #200

@cgwalters cgwalters closed this Nov 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hold waiting on something
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants