kola: Add support for injectContainer
#2999
Conversation
This builds on coreos/coreos-assembler#2999 to test that `rpm -q` works inside the container, which would have caught coreos/fedora-coreos-tracker#1258
|
Demo test: coreos/fedora-coreos-config#1859 |
|
One thing I thought about here is generalizing this to e.g. |
|
Notice here that what will happen normally is we boot the "host system build under test" (qemu/aws/etc) and run the "container image under test" in it. Yet another variant of this is testing using e.g. the stable release host system. Doing that flow would really want something more like the special kola upgrade test flow. Finally of course, a huge thing we could also do here is generalize the old support for |
cgwalters
force-pushed
the
kola-inject-artifact
branch
2 times, most recently
from
f8be7fa to
bce9782
Compare
That's in #3004 ! |
mantle/kola/harness.go
Outdated
| @@ -194,6 +194,9 @@ const ( | |||
| // kolaExtBinDataEnv is an environment variable pointing to the above | |||
| kolaExtBinDataEnv = "KOLA_EXT_DATA" | |||
|
|
|||
| // kolaContainerDataEnv includes the path to the ostree base container image in oci-archive format. | |||
| kolaContainerDataEnv = "KOLA_OSTREE_OCIARCHIVE" | |||
There was a problem hiding this comment.
The other variables follow the pattern kolaExt- which indicates that this constant is used by external tests. Maybe we can rename this to kolaExtContainerDataEnv?
There was a problem hiding this comment.
Fixed! Good suggestion.
Closes: coreos#2952 For quite a while we've been generating a "base image" container as part of our builds, but it has basically been entirely untested outside of its processing and use by the ostree stack. This adds a base framework such that external tests can request the injection of the container (`.ociarchive`). Now, we can (and *definitely* should) also pursue "natively" testing this container image outside of kola, which is very virtual-machine focused. However, that will also require a lot of pipeline changes; this approach allows us to natively "bridge" the worlds of cosa/kola to test the container image.
cgwalters
force-pushed
the
kola-inject-artifact
branch
from
bce9782 to
bd13d3c
Compare
|
/retest |
Closes: #2952
For quite a while we've been generating a "base image" container
as part of our builds, but it has basically been entirely untested
outside of its processing and use by the ostree stack.
This adds a base framework such that external tests can request
the injection of the container (
.ociarchive).Now, we can (and definitely should) also pursue "natively" testing
this container image outside of kola, which is very virtual-machine
focused.
However, that will also require a lot of pipeline changes; this
approach allows us to natively "bridge" the worlds of cosa/kola
to test the container image.